[issue34581] Windows : use of __pragma msvc extension without ifdef

2018-09-04 Thread miss-islington
miss-islington added the comment: New changeset 5b17d7fccd8f0b4d5030b03924eb00904585ba31 by Miss Islington (bot) in branch '3.7': closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067) https://github.com/python/cpython/commit/5b17d7fccd8f0b4d5030b03924eb009045

[issue34581] Windows : use of __pragma msvc extension without ifdef

2018-09-04 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 874809ea389e6434787e773a6054a08e0b81f734 by Benjamin Peterson (Erik Janssens) in branch 'master': closes bpo-34581 : Conditionalize use of __pragma in Modules/socketmodule.c. (GH-9067) https://github.com/python/cpython/commit/874809ea389e643

[issue34581] Windows : use of __pragma msvc extension without ifdef

2018-09-04 Thread miss-islington
Change by miss-islington : -- pull_requests: +8529 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34581] Windows : use of __pragma msvc extension without ifdef

2018-09-04 Thread Erik Janssens
Change by Erik Janssens : -- keywords: +patch pull_requests: +8526 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue34581] Windows : use of __pragma msvc extension without ifdef

2018-09-04 Thread Erik Janssens
New submission from Erik Janssens : The socketmodule uses the MSVC extension __pragma. The use of this extension is not enabled/disable by an #ifdef _MSC_VER. This prevents compilation with other compilers then MSVC on Windows. -- components: Extension Modules messages: 324603 nosy: e