[issue34217] windows: cross compilation fails due to headers with uppercase

Change by Erik Janssens : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mail

[issue34217] windows: cross compilation fails due to headers with uppercase

INADA Naoki added the comment: I'm sorry about that. I won't merge PR like that next time. -- ___ Python tracker ___ ___ Python-bu

[issue34217] windows: cross compilation fails due to headers with uppercase

Steve Dower added the comment: As someone who has written MSDN samples, I'll spoil the secret and let you know that there's no consistency there, so you can find examples to prove either direction ;) I wasn't expecting expertise or research. I was only expecting a description of the change

[issue34217] windows: cross compilation fails due to headers with uppercase

Erik Janssens added the comment: I'll try to be more precise : - I did an (imperfect) search : before these changes 98% of the windows headers were included in the .c files in lowercase - These changes would bring it to 100% - The advantage of these changes are consistency and the ability t

[issue34217] windows: cross compilation fails due to headers with uppercase

INADA Naoki added the comment: I googled and checked what MSDN uses before I merged these PRs. For example: https://msdn.microsoft.com/ja-jp/library/bb394814.aspx -- ___ Python tracker __

[issue34217] windows: cross compilation fails due to headers with uppercase

Steve Dower added the comment: > The current situation is that 100% of the windows includes are lowercase and > allow cross compilation. Please be precise with what you are saying - the "current situation" is only so because you proposed changes and got them merged without proper discussion,

[issue34217] windows: cross compilation fails due to headers with uppercase

Erik Janssens added the comment: As I understand it, if mingw-w64 would change to camelcase headers, it would break backwards compatibility, since a lot of windows source code uses file names in includes that differ from those on this, which works in MSVC, so it goes unnoticed. There is no

[issue34217] windows: cross compilation fails due to headers with uppercase

Steve Dower added the comment: Have you posted to their mailing list to ask why they use different casing from the official SDK and whether they would consider supporting both (via symlink, presumably)? I think it would be strange for CPython to add a style rule for a non-supported toolset.

[issue34217] windows: cross compilation fails due to headers with uppercase

Erik Janssens added the comment: The lowercase headers are indeed part of the mingw-w64 SDK, which is the most convenient option to cross compile on a linux host for a windows target. -- ___ Python tracker

[issue34217] windows: cross compilation fails due to headers with uppercase

Eryk Sun added the comment: > New windows will support case sensitive filesystem too. NTFS in Windows 10 supports a flag to mark a directory as case sensitive [*] via NtSetInformationFile: FileCaseSensitiveInformation, which can be set from the command line via fsutil.exe. In recent builds t

[issue34217] windows: cross compilation fails due to headers with uppercase

Steve Dower added the comment: > whatever might be the 'right' solution, it's always an advantage to > have a consistent codebase. Not when you are consistently wrong, it's not. Let's figure out the right answer here before making many changes to the codebase. First, can you tell me where yo

[issue34217] windows: cross compilation fails due to headers with uppercase

Steve Dower added the comment: > Stop relying to case insensitive filesystem makes sense to me. If this is the case, then we need to normalise the casing to match the actual files (which are mixed-case, not lowercase). You just broke this with your PR :) So which is it? Do we match the casin

[issue34217] windows: cross compilation fails due to headers with uppercase

miss-islington added the comment: New changeset bf8e9d18dd75f58ce3b9761763ae10c0800b43d8 by Miss Islington (bot) in branch '3.7': bpo-34217: Use lowercase for windows headers (GH-8472) https://github.com/python/cpython/commit/bf8e9d18dd75f58ce3b9761763ae10c0800b43d8 --

[issue34217] windows: cross compilation fails due to headers with uppercase

INADA Naoki added the comment: New windows will support case sensitive filesystem too. Stop relying to case insensitive filesystem makes sense to me. -- ___ Python tracker ___

[issue34217] windows: cross compilation fails due to headers with uppercase

Erik Janssens added the comment: @inada.naoki : thank you ! @steve.dower : I would not consider those bugs per se, but they are inconsistencies, for example in the master branch : number of "Windows.h" includes : 2 number of "windows.h" includes : 55 whatever might be the 'right' solution, i

[issue34217] windows: cross compilation fails due to headers with uppercase

Change by miss-islington : -- pull_requests: +8255 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list maili

[issue34217] windows: cross compilation fails due to headers with uppercase

INADA Naoki added the comment: New changeset e6a4755e6793942b950c1595e0c34bd66a0ee13e by INADA Naoki (Erik Janssens) in branch 'master': bpo-34217: Use lowercase for windows headers (GH-8472) https://github.com/python/cpython/commit/e6a4755e6793942b950c1595e0c34bd66a0ee13e -- _

[issue34217] windows: cross compilation fails due to headers with uppercase

Steve Dower added the comment: Are those bugs? On Windows, they are spelled with that casing (and while NTFS is case-insensitive, it *is* case-preserving). Whatever package you have used for cross-compiling may have renamed them (similarly Shlwapi.h). In which case, perhaps you could request

[issue34217] windows: cross compilation fails due to headers with uppercase

Erik Janssens added the comment: Attached a small helper script to detect camelcase windows headers, 2 more occurences found : Modules/socketmodule.c versionhelpers.h 306 #include Tools/msi/bundle/bootstrap/pch.h uxtheme.h 18 #include -- status: closed -> open Added file: https://bu

[issue34217] windows: cross compilation fails due to headers with uppercase

miss-islington added the comment: New changeset 6c89a9a4c7d1804e16038f9ee3a0b2efaa4bdee6 by Miss Islington (bot) in branch '3.7': bpo-34217: Use lowercase header for Windows (GH-8453) https://github.com/python/cpython/commit/6c89a9a4c7d1804e16038f9ee3a0b2efaa4bdee6 -- nosy: +miss-is

[issue34217] windows: cross compilation fails due to headers with uppercase

Change by miss-islington : -- pull_requests: +8074 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34217] windows: cross compilation fails due to headers with uppercase

Change by Erik Janssens : -- pull_requests: +8058 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue34217] windows: cross compilation fails due to headers with uppercase

Change by INADA Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue34217] windows: cross compilation fails due to headers with uppercase

INADA Naoki added the comment: New changeset 6cf8255912c36fec6f87f62513034d0818f61390 by INADA Naoki (erikjanss) in branch 'master': bpo-34217: Use lowercase header for Windows (GH-8453) https://github.com/python/cpython/commit/6cf8255912c36fec6f87f62513034d0818f61390 -- nosy: +inad

[issue34217] windows: cross compilation fails due to headers with uppercase

Change by Erik Janssens : -- keywords: +patch pull_requests: +7978 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue34217] windows: cross compilation fails due to headers with uppercase

New submission from Erik Janssens : When cross compiling python on a linux host with a case sensitive file system for a windows target. The compilation will fail due to header files which contain uppercases. -- components: Cross-Build, Windows messages: 322333 nosy: Alex.Willmer, erik