[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Géry
Géry added the comment: Thanks @xtreak and @vinay.sajip for the fix. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks much @maggyero for the original report and sample test case this was my first non-easy bug fix. Thanks @vinay.sajip for the guidance on logging module implementation. Thanks -- versions: -Python 3.7, Python 3.8 ___

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7, Python 3.8 ___ Python tracker ___ ___

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset b6c1989168efeb8b6320bec958e7e339270ac0ce by Vinay Sajip (Xtreak) in branch '3.6': [3.6] bpo-33978: Close existing handlers before logging (re-)configuration. (GH-8008). (GH-8045) https://github.com/python/cpython/commit/b6c1989168efeb8b6320bec958e

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 6f49afc3d983350f4f04d221a26573721f23c475 by Vinay Sajip (Miss Islington (bot)) in branch '3.7': bpo-33978: Close existing handlers before logging (re-)configuration. (GH-8008) (GH-8044) https://github.com/python/cpython/commit/6f49afc3d983350f4f04

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +7654 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread miss-islington
Change by miss-islington : -- pull_requests: +7653 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-07-02 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 087570af6d5d39b51bdd5e660a53903960e58678 by Vinay Sajip (Xtreak) in branch 'master': bpo-33978: Close existing handlers before logging (re-)configuration. (GH-8008) https://github.com/python/cpython/commit/087570af6d5d39b51bdd5e660a53903960e58678

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-06-29 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +7613 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mai

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-06-29 Thread Xiang Zhang
Change by Xiang Zhang : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-06-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This seems to be a related issue https://bugs.python.org/issue23010 and fix attached but I think it's more towards file handler to be not opened until it's required. Thanks -- ___ Python tracker

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-06-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think while initializing it on the second call we just delete the handlers list variable which contains references to the file handlers instead of properly closing them like it's done in shutdown. handlers is a list of weakreferences and I don't

[issue33978] logging.config.dictConfig with file handler leaks resources

2018-06-27 Thread Géry
New submission from Géry : Calling logging.config.dictConfig several times with a file handler in the same Python process leaks resources. INPUT: $ python3 -Wall < self.common_logger_config(root, config, incremental) -- components: Library (Lib) messages: 320560 nosy: maggyero prior