[issue33729] Hashlib/blake2* missing 'data' keyword argument

Ned Deily added the comment: Serhiy's fixes (thanks!) are now released in 3.7.0rc2 and 3.6.7rc2 so I'm removing the "release blocker" status. If there is nothing more to be done for this issue, can we close it? -- priority: release blocker -> __

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: New changeset f543e18708efb04ed3a0b78c8dc31fbb1404ac7d by Serhiy Storchaka in branch '3.6': [3.6] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) (GH-8581) (GH-9657) https://github.com/python/cpython/commit/f543e18708efb04ed3a0b78c8dc31f

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: Other variant of the crash in issue34922 still is reproducible in 3.7. -- ___ Python tracker ___ __

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: I have reviewed PR 8346 yet one time. No documented working behavior was changed. Some documentation was updated to match the code, some code was updated to match the documentation, and other minor errors were fixed. I don't think this change breaks compat

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Ned Deily added the comment: The question remains if Christian's and Victor's concern with 3.7 compatibility have been satisfied by Serihy's response in msg322798. While there is plenty of time to resolve concerns about what was merged into master by PR 8346, we shouldn't release the PR 8581

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Ned Deily added the comment: OK. This is now blocking the release of 3.7.1rc2 and 3.6.7rc2. See also Issue34922. -- priority: normal -> release blocker ___ Python tracker __

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Christian Heimes added the comment: Ned, I'm currently travelling until next weekend. The PR is rather large and I don't have any means or time to review it properly. Perhaps Gregory or Dmitry Chestnykh (original author of pyblake2) are able to assist. -- nosy: +gregory.p.smith

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Ned Deily added the comment: What's the status of this issue for 3.7 and for 3.6? Is everyone OK with what is currently in 3.7, i.e. no revert needed or has it already been reverted elsewhere? Also, there is the open PR for 3.6. -- nosy: +ned.deily

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Change by Serhiy Storchaka : -- pull_requests: +9049 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: In case of int() the name of it's first argument was documented, in both the module documentation, and in interactive help. But the documented name of the first blake2b() argument was "data", and it never worked. Since help() was not worked for blake2b, th

[issue33729] Hashlib/blake2* missing 'data' keyword argument

STINNER Victor added the comment: I have no opinion on the change in the master branch, but I agree with Christian that the 3.7 change should be reverted since it breaks the backward compatibility. Serhiy modified int() in Python 3.7 to convert its first parameter to positional only paramet

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: Sorry. Do you prefer to revert the whole changes or just some parts? -- ___ Python tracker ___

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Christian Heimes added the comment: The backport to 3.6 and 3.7 are breaking backwards compatibility and compatibility with PEP 247. -- ___ Python tracker ___ ___

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Christian Heimes added the comment: Your PR changed way to many aspects of the code in one commit. I also don't like the fact, that you pushed such a big change without waiting for my feedback. For the past two weeks I have been travelling to conferences and had no time to review your PR. Th

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: New changeset 47957dab94a4efa2fee61c9a8193f78300950769 by Serhiy Storchaka in branch '3.7': [3.7] bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) (GH-8581) https://github.com/python/cpython/commit/47957dab94a4efa2fee61c9a8193f78300950769

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Change by Serhiy Storchaka : -- pull_requests: +8090 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: New changeset f1d36d8efaecd5c84cb35e35119b283f37d83c40 by Serhiy Storchaka in branch 'master': bpo-33729: Fix issues with arguments parsing in hashlib. (GH-8346) https://github.com/python/cpython/commit/f1d36d8efaecd5c84cb35e35119b283f37d83c40 --

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +7881 stage: -> patch review ___ Python tracker ___ ___ Python-bugs

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: I take this issue because there are many other issues with handling arguments in the hashlib module. -- ___ Python tracker ___ ___

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Change by Serhiy Storchaka : -- assignee: docs@python -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Christian Heimes added the comment: Please treat the first argument as positional-only argument. I don't want to standardize on 'string'. -- ___ Python tracker ___ __

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Serhiy Storchaka added the comment: hashlib.blake2b() and some other constructors accept the first chunk of data as the "string" keyword argument. >>> hashlib.blake2b(string=b'') <_blake2.blake2b object at 0x7f2847a9c430> >>> hashlib.blake2s(string=b'') <_blake2.blake2s object at 0x7f28468f62

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Karthikeyan Singaravelan added the comment: This was introduced as part of https://hg.python.org/cpython/rev/4969f6d343b1 . In addition to the signature there is also a line at https://docs.python.org/dev/library/hashlib.html#simple-hashing which could be removed > As a shortcut, you can p

[issue33729] Hashlib/blake2* missing 'data' keyword argument

STINNER Victor added the comment: > None of the hashlib functions are taking keyword arguments for data: ... So it's just a documentation issue, no? https://docs.python.org/dev/library/hashlib.html#creating-hash-objects Juuso Lehtivarjo: do you want to write a pull request to fix the documen

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Christian Heimes added the comment: None of the hashlib functions are taking keyword arguments for data: >>> hashlib.sha256(data=b'foo') Traceback (most recent call last): File "", line 1, in TypeError: openssl_sha256() takes no keyword arguments >>> hashlib.blake2b(data=b'foo') Traceback (

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Change by Serhiy Storchaka : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue33729] Hashlib/blake2* missing 'data' keyword argument

Change by Ned Deily : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue33729] Hashlib/blake2* missing 'data' keyword argument

New submission from Juuso Lehtivarjo : In python 3.6.5: hashlib blake2b/blake2s constructors do not recognize 'data' keyword. Try the following: from hashlib import blake2b print (blake2b(b"foobar").hexdigest()) # works print (blake2b(data=b"foobar").hexdigest()) # TypeError: 'data' is an inva