[issue33687] uu.py calls os.path.chmod which doesn't exist

Berker Peksag added the comment: Thank you for the report, Poul-Henning and thank you for the PR, Timo! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.6 ___ Python tracker

[issue33687] uu.py calls os.path.chmod which doesn't exist

Berker Peksag added the comment: New changeset a261b737617ca8d52e04bf3ead346b1b8786a212 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-33687: Fix call to os.chmod() in uu.decode() (GH-7282) https://github.com/python/cpython/commit/a261b737617ca8d52e04bf3ead346b1b8786a212 -

[issue33687] uu.py calls os.path.chmod which doesn't exist

Change by Berker Peksag : -- pull_requests: -11290 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue33687] uu.py calls os.path.chmod which doesn't exist

Change by miss-islington : -- pull_requests: +11289, 11290 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue33687] uu.py calls os.path.chmod which doesn't exist

Berker Peksag added the comment: New changeset 17f05bbc78dbcd1db308266c31370da9ec1b1d47 by Berker Peksag (Timo Furrer) in branch 'master': bpo-33687: Fix call to os.chmod() in uu.decode() (GH-7282) https://github.com/python/cpython/commit/17f05bbc78dbcd1db308266c31370da9ec1b1d47 --

[issue33687] uu.py calls os.path.chmod which doesn't exist

STINNER Victor added the comment: > Please note that the mode is not just a parameter, it is also a data field > inside the encoded input. Oh... right... " is the file's Unix file permissions as three octal digits (e.g. 644, 744). This is typically only significant to unix-like operating s

[issue33687] uu.py calls os.path.chmod which doesn't exist

Poul-Henning Kamp added the comment: Please note that the mode is not just a parameter, it is also a data field inside the encoded input. See: https://en.wikipedia.org/wiki/Uuencoding (search for "mode") -- ___ Python tracker

[issue33687] uu.py calls os.path.chmod which doesn't exist

STINNER Victor added the comment: Is there really an use case which requires to set the permission of the file created by uu.decode()? It is already possible to call uu.decode() with an open file which has been created with the expected permission. Moreover, it's also possible to explicitly

[issue33687] uu.py calls os.path.chmod which doesn't exist

Serhiy Storchaka added the comment: But 'xb' should be used only if out_file is not specified. -- ___ Python tracker ___ ___ Python

[issue33687] uu.py calls os.path.chmod which doesn't exist

Serhiy Storchaka added the comment: I concur with Martin. If this feature never worked, there is a risk of breaking user code when fix it. Let consider this as adding a new feature in 3.8. For older versions it should be documented that the mode of the output file is not set. And I agree th

[issue33687] uu.py calls os.path.chmod which doesn't exist

Poul-Henning Kamp added the comment: I was just playing with it in a prototype and noticed that it didn't work. -- ___ Python tracker ___ _

[issue33687] uu.py calls os.path.chmod which doesn't exist

STINNER Victor added the comment: > It looks like the module has never set the file mode, at least since it was > added to Python in 1994. I suggest just remove the dead code and fix the > documentation. You cannot just remove the mode parameter without a deprecation period. Right now, the

[issue33687] uu.py calls os.path.chmod which doesn't exist

Martin Panter added the comment: What is your use case, Poul-Henning? It looks like the module has never set the file mode, at least since it was added to Python in 1994. I suggest just remove the dead code and fix the documentation. At least you shouldn’t make this change in bug fix releases

[issue33687] uu.py calls os.path.chmod which doesn't exist

Change by Xiang Zhang : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue33687] uu.py calls os.path.chmod which doesn't exist

Xiang Zhang added the comment: I modified it for the feature, not maintain it. I remember at that time I get the feeling it's somewhat strange there are two APIs, with similar functionality resides in two modules, need to be updated. -- nosy: -r.david.murray ___

[issue33687] uu.py calls os.path.chmod which doesn't exist

R. David Murray added the comment: The email module uses it, so I would object to its being removed. It may not be used often (probably only when working with old email archives), but there's no good reason I can see to break something that currently works. -- nosy: +r.david.murray

[issue33687] uu.py calls os.path.chmod which doesn't exist

STINNER Victor added the comment: Is the uu module still maintained? Christian Heimes wants to remove the module: https://github.com/tiran/peps/blob/oldbatteries/pep-.rst Xiang Zhang made a change in uu last year to add a new feature: new backtick optional parameter, bpo-30103. -

[issue33687] uu.py calls os.path.chmod which doesn't exist

Timo Furrer added the comment: I've added a test and updated the PR. -- nosy: +tuxtimo ___ Python tracker ___ ___ Python-bugs-list

[issue33687] uu.py calls os.path.chmod which doesn't exist

Serhiy Storchaka added the comment: Would be nice to add a test. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue33687] uu.py calls os.path.chmod which doesn't exist

Change by Timo Furrer : -- keywords: +patch pull_requests: +6908 stage: needs patch -> patch review ___ Python tracker ___ ___ Pytho

[issue33687] uu.py calls os.path.chmod which doesn't exist

Change by Serhiy Storchaka : -- keywords: +easy stage: -> needs patch versions: +Python 3.7, Python 3.8 ___ Python tracker ___ ___

[issue33687] uu.py calls os.path.chmod which doesn't exist

Serhiy Storchaka added the comment: Looks as the proper fix to me. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bug

[issue33687] uu.py calls os.path.chmod which doesn't exist

New submission from Poul-Henning Kamp : Library file uu.py on at least 2.7 and 3.6 contains: try: os.path.chmod(out_file, mode) except AttributeError: pass As far as I can tell, os.path.chmod does not exist, so this always raises Attribu