[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Summary for users: Previously, Code Context displayed a fixed number of lines. Often, many were blank. Hence the default *numlines* to display was small, 3, to avoid having too many blank lines. However, 3 is often too small to display the complete contex

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am leaving this open until the new behavior is documented, even though it might be part of another issue that includes other context changes. For this issue, I will leave what happens when unzooming unspecific. -- _

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread miss-islington
miss-islington added the comment: New changeset a42fe3c67ca86ac08dc6f47af27eed089d35fdd0 by Miss Islington (bot) in branch '3.6': bpo-33642: IDLE: Use variable number of lines in CodeContext. (GH-7106) https://github.com/python/cpython/commit/a42fe3c67ca86ac08dc6f47af27eed089d35fdd0 ---

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread miss-islington
miss-islington added the comment: New changeset 0800b6c17a829ecb554d93cba8c97f92b15be52a by Miss Islington (bot) in branch '3.7': bpo-33642: IDLE: Use variable number of lines in CodeContext. (GH-7106) https://github.com/python/cpython/commit/0800b6c17a829ecb554d93cba8c97f92b15be52a ---

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread miss-islington
Change by miss-islington : -- pull_requests: +6964 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread miss-islington
Change by miss-islington : -- pull_requests: +6963 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 29996a1c4e8bd6dde6adce2b44d11a0982a47a3a by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-33642: IDLE: Use variable number of lines in CodeContext. (GH-7106) https://github.com/python/cpython/commit/29996a1c4e8bd6dde6adce2b44d11a0982a

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-06-01 Thread Cheryl Sabella
Cheryl Sabella added the comment: I see similar behavior on Linux, except after maximizing and then minimizing, it seems to stay with option 2. -- ___ Python tracker ___

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-31 Thread Terry J. Reedy
Terry J. Reedy added the comment: On Windows, I observe the following behaviors. 1. When Code Context is enabled on a windows still at its initial height, context lines are added to code lines to increase the window height. 2. When the window height is changed with a mouse, that becomes the

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-28 Thread Cheryl Sabella
Cheryl Sabella added the comment: I pushed a commit for these three items. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: After testing the patch as a user, I would like 3 user-visible changes. 1. Only display a blank line when there are no context lines. 2. Replace the 'lines' option with a 'maxlines' option. There is no need to worry about, or explain to users (see 3.) the po

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-27 Thread Terry J. Reedy
Terry J. Reedy added the comment: Unlinked duplicate PR entry. I have no idea how that could happen. -- ___ Python tracker ___ ___

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-27 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: -6745 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-25 Thread Cheryl Sabella
Cheryl Sabella added the comment: I know we usually don't change defaults, but I had tested this one and I think it works. After I changed it to 15 lines in master, I opened the installed version of IDLE 2.7. Although it showed 15 fixed lines, it made sense since that was the number of line

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: 2 quick thoughts. 1. I am not sure we can/should change the default, as it interacts with the recorded user changes for past versions. The default is that we never change defaults. (Having one user config for all Python/IDLE versions is a curse as well as

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-24 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch, patch pull_requests: +6744, 6745 stage: -> patch review ___ Python tracker ___ ___ P

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-24 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +6744 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue33642] IDLE: Use variable number of lines in CodeContext

2018-05-24 Thread Cheryl Sabella
New submission from Cheryl Sabella : Item 7 from #33610: Change fixed # of lines to variable # of lines as needed, up to limit. About 15 is limit for 4-space indents in 80 char lines. * Change default number of lines to be 15 in config. * Label in config dialog. * Initialize context to be one