[issue33639] Use high-performance os.sendfile() in shutil.copy*

Giampaolo Rodola' added the comment: Closing as duplicate of #33671. -- stage: resolved -> patch review ___ Python tracker ___ ___ P

[issue33639] Use high-performance os.sendfile() in shutil.copy*

Giampaolo Rodola' added the comment: Closing as duplicate of #33671. -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> Efficient zero-copy for shutil.copy* functions (Linux, OSX and Win) ___ Python t

[issue33639] Use high-performance os.sendfile() in shutil.copy*

Giampaolo Rodola' added the comment: I updated the code to rely on sendfile(2) on Linux only, which apparently is the only one supporting copy between regular files and added a check to fail immediately in case the filesystem is full. Can somebody review the patch? -- _

[issue33639] Use high-performance os.sendfile() in shutil.copy*

STINNER Victor added the comment: > I'm a bit depressed by the number of issues here that have a good patch > waiting to be merged, or even read, and that languish for years. I'm really sorry about that. We, core developers, are doing our best, but we are 34 active core developers who merged

[issue33639] Use high-performance os.sendfile() in shutil.copy*

desbma added the comment: Honestly, whatever gets this thing moving forward is good with me. I'm a bit depressed by the number of issues here that have a good patch waiting to be merged, or even read, and that languish for years. I haven't read your patch in detail, but if others agree that i

[issue33639] Use high-performance os.sendfile() in shutil.copy*

Giampaolo Rodola' added the comment: Oh! I got confused by the fact that #25063 was rejected due to concerns about copyfileobj() otherwise I would have commented on your patch which I totally missed. Yes, this overlaps with #25156 patch but it uses the same logic of socket.sendfile() which IM

[issue33639] Use high-performance os.sendfile() in shutil.copy*

desbma added the comment: Duplicate of https://bugs.python.org/issue25156 ? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue33639] Use high-performance os.sendfile() in shutil.copy*

Change by Giampaolo Rodola' : -- keywords: +patch pull_requests: +6737 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue33639] Use high-performance os.sendfile() in shutil.copy*

New submission from Giampaolo Rodola' : This is a follow up of #25063 and similar to socket.sendfile() (#17552). It provides a 20/25% speedup when copying files with shutil.copyfile(), shutil.copy() and shutil.copy2(). Differently from #25063 this is used for filesystem files only and copyfile