[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-24 Thread STINNER Victor
STINNER Victor added the comment: > I've pushed a commit that should fix the buildbot. Please reopen if it > doesn't. test_context and test_asyncio do'nt crash anymore on this buildbot, thanks Yury. test_asyncio still fail on this buildbot, I created a new issue: bpo-32645, test_asyncio: TLS

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset b7a80d543e1e94475ab9c8214f7a9eab4e63c9ab by Yury Selivanov in branch 'master': bpo-32436: Don't use native popcount() (also fixes bpo-32641) (#5292) https://github.com/python/cpython/commit/b7a80d543e1e94475ab9c8214f7a9eab4e63c9ab -- re

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Yury Selivanov added the comment: I've pushed a commit that should fix the buildbot. Please reopen if it doesn't. -- ___ Python tracker ___

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Yury Selivanov added the comment: In an off-list conversation with David, it was confirmed that the buildbot in question runs on an old hardware without SSE4.2 support. I decided to simply stop using native popcount instructions as there's no detectable performance difference when using them

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +5139 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread STINNER Victor
STINNER Victor added the comment: > I suspect this is a compiler bug. It may be interesting to add the compiler version to test.pythoninfo. It would be simpler to compare Windows buildbots to identify a bug. Currently, the only info is: "sys.version: 3.7.0a4+ (heads/master:9d411c1, Jan 23 20

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +db3l ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Yury Selivanov added the comment: I suspect this is a compiler bug. I can't reproduce it on my windows 7 virtual machine and on AppVeyor. It's not related to HAMT, btw, as there is a multitude of HAMT-specific tests that all pass. The crash is specifically in context.c, and the code there i

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Yury Selivanov added the comment: No, these are trivial uint32_t/Py_SIZE: `for (uint32_t i = val_idx + 1; i < Py_SIZE(o); i++)`; it's something else. I suspect popcount instruction... -- ___ Python tracker

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread STINNER Victor
STINNER Victor added the comment: Some hints. Compiler warnings: ..\Python\hamt.c(625): warning C4018: '<': signed/unsigned mismatch [D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\pythoncore.vcxproj] ..\Python\hamt.c(733): warning C4018: '<': signed/unsigned mismatch [D:\cygw

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread Yury Selivanov
Yury Selivanov added the comment: It's not a regression, the newly added code doesn't work on some Windows buildbot... looking at it. -- ___ Python tracker ___ ___

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread STINNER Victor
STINNER Victor added the comment: test_asyncio started to crash at build 491: http://buildbot.python.org/all/#/builders/58/builds/491 This build contains the commit f23746a934177c48eff754411aba54c31d6be2f0: "bpo-32436: Implement PEP 567". I'm not 100% sure that it's the cause of the regressi

[issue32641] test_context and test_asyncio crash on Windows 7

2018-01-23 Thread STINNER Victor
New submission from STINNER Victor : http://buildbot.python.org/all/#/builders/58/builds/498 0:36:25 [252/414/1] test_context crashed (Exit code 3) -- running: test_largefile (239 sec) Windows fatal exception: code 0xc01d Current thread 0x0944 (most recent call first): File "D:\cygw