[issue3259] fix_imports needs to be using the 'as' keyword

2008-07-02 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- resolution: -> invalid ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list

[issue3259] fix_imports needs to be using the 'as' keyword

2008-07-02 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Gotcha. Here is to hoping that won't cause issues with someone's variable name being silly. -- status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3259] fix_imports needs to be using the 'as' keyword

2008-07-02 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Yeah, but then commands will be replaced with subprocess. $ cat > m import commands commands.getoutput() $ 2to3 m RefactoringTool: Skipping implicit fixer: buffer RefactoringTool: Skipping implicit fixer: idioms RefactoringTool: Skipping i

[issue3259] fix_imports needs to be using the 'as' keyword

2008-07-02 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: If you run ``echo "import commands" | ./2to3 -f imports -``, you end up with ``import subprocess``. That's bad as the code in the module works off of 'commands'. The fix really should be ``import subprocess as commands``. -- assignee: