[issue32533] SSLSocket read/write thread-unsafety

Steve Dower added the comment: Fixed, with a fix for the regression coming in issue34759 -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32533] SSLSocket read/write thread-unsafety

Steve Dower added the comment: New changeset 1a107eea8e91e50c5c9025e945c78eb1aa9b874d by Steve Dower in branch '3.6': bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158) https://github.com/python/cpython/commit/1a107eea8e91e50c5c9025e945c78eb1aa9b874d -- ___

[issue32533] SSLSocket read/write thread-unsafety

Change by Steve Dower : -- pull_requests: +8789 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue32533] SSLSocket read/write thread-unsafety

miss-islington added the comment: New changeset 1229664f30dd5fd4da32174a19258f8312464d45 by Miss Islington (bot) in branch '3.7': bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158) https://github.com/python/cpython/commit/1229664f30dd5fd4da32174a19258f8312464d45 --

[issue32533] SSLSocket read/write thread-unsafety

Change by miss-islington : -- pull_requests: +8787 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue32533] SSLSocket read/write thread-unsafety

Steve Dower added the comment: New changeset c6fd1c1c3a65217958b68df3a4991e4f306e9b7d by Steve Dower in branch 'master': bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158) https://github.com/python/cpython/commit/c6fd1c1c3a65217958b68df3a4991e4f306e9b7d --

[issue32533] SSLSocket read/write thread-unsafety

Change by Steve Dower : -- keywords: +patch pull_requests: +6794 stage: needs patch -> patch review ___ Python tracker ___ ___ Python

[issue32533] SSLSocket read/write thread-unsafety

Steve Dower added the comment: We don't have a roadmap, just volunteers. When someone is sufficiently motivated to work on it, it will happen. (You're welcome to try and motivate people with reason, pleading, money and/or abuse, though I don't recommend the last one :) Money doesn't work eith

[issue32533] SSLSocket read/write thread-unsafety

Alfred Krohmer added the comment: Is there anything on the roadmap to fix this? This is a pretty severe bug given that this breaks multi-threaded OpenSSL while the documentation says it's thread-safe. -- nosy: +devkid ___ Python tracker

[issue32533] SSLSocket read/write thread-unsafety

Change by James Lu : -- nosy: +tacocat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue32533] SSLSocket read/write thread-unsafety

Change by Christian Heimes : -- assignee: christian.heimes -> steve.dower stage: -> needs patch versions: +Python 3.8 ___ Python tracker ___ ___

[issue32533] SSLSocket read/write thread-unsafety

Alexey Baldin added the comment: I'd gather errno and win error into local variables (or struct) just after SSL call and then pass them to PySSL_SetError. -- ___ Python tracker __

[issue32533] SSLSocket read/write thread-unsafety

Steve Dower added the comment: Almost seems like an unwinnable race here. We need to collect the error numbers before reacquiring the GIL (which could change some of them), but then if we update the object after getting the lock back we could still have raced with another thread. Perhaps we

[issue32533] SSLSocket read/write thread-unsafety

Change by Christian Heimes : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32533] SSLSocket read/write thread-unsafety

New submission from Alexey Baldin : _ssl.c has thread-usafe code in implementation of read, write and other methods. E.g. 'write' method: 2099PySSL_BEGIN_ALLOW_THREADS 2100len = SSL_write(self->ssl, b->buf, (int)b->len); 2101_PySSL_UPDATE_ERRNO_IF(len <= 0, self, len); 2