[issue32430] Simplify Modules/Setup{,.dist,.local}

STINNER Victor added the comment: > PR GH-5062 is still open in GitHub, is this PR still required? It's not. I closed it, thanks. -- ___ Python tracker ___ __

[issue32430] Simplify Modules/Setup{,.dist,.local}

anthony shaw added the comment: PR GH-5062 is still open in GitHub, is this PR still required? -- nosy: +anthony shaw ___ Python tracker ___ __

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Julien Palard : -- pull_requests: +8537 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32430] Simplify Modules/Setup{,.dist,.local}

STINNER Victor added the comment: Thank you Antoine for fixing this issue! This issue annoyed me forever, but I never tried to fix it. It was very annoying when using git bisect for example. -- ___ Python tracker

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: With PR #8229 pushed the distinction between Setup.dist and Setup has disappeared: you have a Modules/Setup file in the source tree and that's where you do any changes, which you are responsible to track yourself (e.g. using a patch file or a git fork). ---

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: New changeset 961d54c5c1916c09883ebcf7191babc969e5a5cf by Antoine Pitrou in branch 'master': bpo-32430: Rename Modules/Setup.dist to Modules/Setup (GH-8229) https://github.com/python/cpython/commit/961d54c5c1916c09883ebcf7191babc969e5a5cf -- __

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue32430] Simplify Modules/Setup{,.dist,.local}

Neil Schemenauer added the comment: I removed the "makesetup_fallback_dist.txt". PR-8260 is a more polished implementation of the same idea. -- ___ Python tracker ___ __

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Neil Schemenauer : Removed file: https://bugs.python.org/file47685/makesetup_fallback_dist.txt ___ Python tracker ___ ___ Python-b

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Neil Schemenauer : -- pull_requests: +7793 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Neil Schemenauer : Added file: https://bugs.python.org/file47685/makesetup_fallback_dist.txt ___ Python tracker ___ ___ Python-bug

[issue32430] Simplify Modules/Setup{,.dist,.local}

Neil Schemenauer added the comment: PR 8229 doesn't work if the build dir is separate from the src dir (mentioned in the PR comments). The attached patch (makesetup_fallback_dist.txt) changes makesetup to fallback to using $srcdir/Modules/Setup.dist if Modules/Setup doesn't exist. I remove

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: I've created a PR that renames Setup.dist to Setup and removes extraneous logic. -- ___ Python tracker ___ __

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Antoine Pitrou : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Antoine Pitrou : -- pull_requests: +7767 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Kubilay Kocak : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue32430] Simplify Modules/Setup{,.dist,.local}

Julien Palard added the comment: Taking arguments into account, this solution may work: - Continue to distribute a Setup.dist - Add a configure option to change it, as Victor said --setup-file should do it, the default value should be Setup.dist - Remove the `cp Setup.dist Setup` This soluti

[issue32430] Simplify Modules/Setup{,.dist,.local}

Xavier de Gaye added the comment: A solution to this issue must deal with the following use case: A developer has made changes to Modules/Setup and is tracking these changes in a VCS, for example with mercurial or with a git submodule through a symlink. By the time he is about to pull the com

[issue32430] Simplify Modules/Setup{,.dist,.local}

Xavier de Gaye added the comment: I fully concur with all points in Victor msg310345. -- ___ Python tracker ___ ___ Python-bugs-list

[issue32430] Simplify Modules/Setup{,.dist,.local}

Julien Palard added the comment: I don't see a use case where one want to edit a file without having his work being tracked by git, can someone shed a light to me on this? I understand that to modify a single configuration point (a path, whatever) a configure option is the right way and is no

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: Le 20/01/2018 à 14:22, STINNER Victor a écrit : > > I don't see how adding an option to make one path configurable would make the > build process more complicated. Do you think implementing and maintaing an option has no cost? > It seems like Xavier and Thom

[issue32430] Simplify Modules/Setup{,.dist,.local}

STINNER Victor added the comment: > Because we don't want to maintain more config options? Really, I don't to > want to further complicate our build process. I don't see how adding an option to make one path configurable would make the build process more complicated. It seems like Xavier an

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: > Why not adding an option in Makefile or configure to allow to specify a > different path to a custom Setup file? Because we don't want to maintain more config options? Really, I don't to want to further complicate our build process. -- __

[issue32430] Simplify Modules/Setup{,.dist,.local}

STINNER Victor added the comment: I like the idea of removing the Modules/Setup.dist => Modules/Setup copy which removes immediately the annoying warning (bpo-32429). > ... that one can modify and commit I'm not sure about the "commit" part. I see Modules/Setup as a configuration file. Pytho

[issue32430] Simplify Modules/Setup{,.dist,.local}

Thomas Wouters added the comment: We do use Setup/Setup.local at Google (and have for many years now), and I find it very useful. (FWIW, the 'we would use' comment in msg294174 was about the new '*disabled*' feature, not about Setup files in general.) Avoiding local changes is also important

[issue32430] Simplify Modules/Setup{,.dist,.local}

Martin Panter added the comment: FWIW there was documentation in the README about the Setup files, removed in Subversion r57681 (= Git revision 1c896e3). It looks like it still survives in the 2.7 version. -- nosy: +martin.panter ___ Python tracker

[issue32430] Simplify Modules/Setup{,.dist,.local}

Julien Palard added the comment: I also think PR 5062 complicate the thing I'm trying to simplify, it's the wrong direction. I also don't understand why having a single versioned `Setup` file is not enough, can someone give a clear explanation on this point? -- _

[issue32430] Simplify Modules/Setup{,.dist,.local}

Xavier de Gaye added the comment: Yes 3.8 and this leaves plenty of time for writing some documentation on the build process :-) -- ___ Python tracker ___

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: First, I would count Google in the extremely skilled category :-) (cc'ing Thomas so that he can chime in) Second, if someone are doing a custom build of Python, they are very likely modifying something else than Modules/Setup (*). So they already have some k

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: > It is annoying that there is no documentation on the build process that can > be modified to describe the deprecation in details. Do you think a What'sNew > entry is sufficient ? Yes, I think so. Also my hope is to remove it in 3.8 :-) -- ___

[issue32430] Simplify Modules/Setup{,.dist,.local}

Xavier de Gaye added the comment: > and I've never seen it done by anyone else In msg294174 Thomas says he intends to use it for Python at Google in order to "avoid third-party libraries even when they are available on the build system". I do not have a strong opinion about this. Implementing

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: Note the use case we're trying to preserve here is probably extremely rare. I've never needed it myself, and I've never seen it done by anyone else. We're talking about a very small demographics who's probably skilled enough to handle a little complexity in

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: I would hope to simplify the build process, not to complicate it. In other words, I think the PR is a step in the wrong direction, *except* if using Setup.dist becomes the default and the other way is clearly marked deprecated. -- __

[issue32430] Simplify Modules/Setup{,.dist,.local}

Xavier de Gaye added the comment: The Setup files are configuration files, so their handling is different from the handling of Makefile.pre.in or the handling of the source files. The only reference to Setup.local in the Python documentation is at https://docs.python.org/3/extending/extending

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Xavier de Gaye : -- keywords: +patch pull_requests: +4938 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue32430] Simplify Modules/Setup{,.dist,.local}

Antoine Pitrou added the comment: > Personally I'll go for a single Setup file (No .dist, no .local, no copy), > that one can modify and commit, delegating the pain of merging to git, as I > prefer simple solutions. +1 for this. -- nosy: +barry, pitrou type: -> enhancement versions:

[issue32430] Simplify Modules/Setup{,.dist,.local}

New submission from Julien Palard : Related to: https://bugs.python.org/issue32429 The bahavior of Modules/Setup{,.dist,.local} looks inherited from an old time: - A Setup.dist exist - ./configure copies it to Setup (cp $srcdir/Modules/Setup.dist Modules/Setup) - ./configure installs a dummy M

[issue32430] Simplify Modules/Setup{,.dist,.local}

Change by Julien Palard : -- components: +Build versions: +Python 2.7, Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-