[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Terry J. Reedy added the comment: yes ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

miss-islington added the comment: New changeset ac60d1afd2b04f61fe4c965740fa32809f2b84ed by Miss Islington (bot) in branch '3.7': bpo-32411: IDLE: Remove line number sort in browser.py (GH-5011) https://github.com/python/cpython/commit/ac60d1afd2b04f61fe4c965740fa32809f2b84ed -- nos

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Change by miss-islington : -- pull_requests: +13616 pull_request: https://github.com/python/cpython/pull/13732 ___ Python tracker ___ __

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Terry J. Reedy added the comment: New changeset 1a4d9ffa1aecd7e750195f2be06d3d16c7a3a88f by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-32411: IDLE: Remove line number sort in browser.py (#5011) https://github.com/python/cpython/commit/1a4d9ffa1aecd7e750195f2be06d3d16c7a3a88f -

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Raymond Hettinger added the comment: Can this move forward now? -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list ma

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Terry J. Reedy added the comment: I should mention that using Treeview could mean not using pyclbr.Instead, we might extract the parsing loop and modify it to build tree nodes as functions and classes are encountered. -- ___ Python tracker

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Terry J. Reedy added the comment: The patch is trivial, and I assume that the test change is adequate, but I want to put this issue on hold for the present because a) the performance gain is minuscule (the code cleanup is worth a bit more); b) I am reluctant to backport something to 3.6 that de

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Cheryl Sabella added the comment: Terry, I'm not sure if I phrased my initial question correctly. I've made a pull request to show you what I was thinking. What I had tried to show with the test case change is that, prior to the guarantee of insertion order on the dictionary, the check `eq(

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +4900 stage: test needed -> patch review ___ Python tracker ___ ___ Pyt

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Terry J. Reedy added the comment: (f0, C0) is the correct insertion and line number order for the dict that would be returned by pyclbr for a fleshed-out file. After 'sorted' is removed, the mock must imitate that. One could argue that previously, and even now for 3.6, the initial insertion

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

Cheryl Sabella added the comment: Terry, In test_browser, would it be a good test if mock_pyclbr_tree was created as `mock_pyclbr_tree = {'C0': C0, 'f0': f0}` instead of `mock_pyclbr_tree = {'f0': f0, 'C0': C0}`? The reason that I'm asking is that, under 2.7 and 3.3, this dictionary does no

[issue32411] Idlelib.browser: stop sorting dicts created by pyclbr

New submission from Terry J. Reedy : pyclbr does a linear scan of a file and returns a dict, and Class objects have a dict of children. For objects in the file being scanned, insertion order is the same as line number order. idlelib.browser.transform children filters out objects not in the fi