[issue32392] subprocess.run documentation does not have **kwargs

2018-06-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue32392] subprocess.run documentation does not have **kwargs

2018-06-07 Thread Berker Peksag
Berker Peksag added the comment: New changeset 279564431e8e2fa4c20e8850420caea484a5d20b by Berker Peksag in branch '3.6': [3.6] bpo-32392: Document env keyword argument of subprocess.run() (GH-7289) https://github.com/python/cpython/commit/279564431e8e2fa4c20e8850420caea484a5d20b --

[issue32392] subprocess.run documentation does not have **kwargs

2018-06-07 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +7114 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32392] subprocess.run documentation does not have **kwargs

2018-06-05 Thread miss-islington
miss-islington added the comment: New changeset 23b7ee205270320f836e93e411b28ac995cbabf1 by Miss Islington (bot) in branch '3.7': bpo-32392: Document env keyword argument of subprocess.run() (GH-7289) https://github.com/python/cpython/commit/23b7ee205270320f836e93e411b28ac995cbabf1

[issue32392] subprocess.run documentation does not have **kwargs

2018-06-05 Thread miss-islington
Change by miss-islington : -- pull_requests: +7048 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue32392] subprocess.run documentation does not have **kwargs

2018-06-05 Thread Berker Peksag
Berker Peksag added the comment: New changeset af1ec97a6d1dde68b2dc0ee9b78965eb219061a8 by Berker Peksag (Tobias Kunze) in branch 'master': bpo-32392: Document env keyword argument of subprocess.run() (GH-7289) https://github.com/python/cpython/commit/af1ec97a6d1dde68b2dc0ee9b78965eb219061a8

[issue32392] subprocess.run documentation does not have **kwargs

2018-05-31 Thread Tobias Kunze
Change by Tobias Kunze : -- keywords: +patch pull_requests: +6916 stage: needs patch -> patch review ___ Python tracker ___ ___ Pyth

[issue32392] subprocess.run documentation does not have **kwargs

2018-05-16 Thread Xavier de Gaye
Xavier de Gaye added the comment: > Let's add 'env=None' to the signature of subprocess.run(): +1 -- ___ Python tracker ___ ___ Pyt

[issue32392] subprocess.run documentation does not have **kwargs

2018-05-16 Thread Berker Peksag
Berker Peksag added the comment: I agree with Xavier's comment, but I've bitten by this before so I think it would be better if we add more common arguments to the subprocess.run() signature. Adding **kwargs wouldn't be entirely correct since subprocess.run() doesn't pass all its arguments t

[issue32392] subprocess.run documentation does not have **kwargs

2017-12-20 Thread Oleh Prypin
Oleh Prypin added the comment: Yes, but the most prominent thing to indicate that is **kwargs in the actual function signature. And, as far as I'm concerned, lack of **kwargs means the function signature is exhaustive and there's no point in looking for fine print somewhere in the middle of t

[issue32392] subprocess.run documentation does not have **kwargs

2017-12-20 Thread Xavier de Gaye
Xavier de Gaye added the comment: But the documentation does say "The arguments shown above are merely the most common ones...The full function signature is largely the same as that of the Popen constructor...", no ? -- nosy: +xdegaye ___ Python tr

[issue32392] subprocess.run documentation does not have **kwargs

2017-12-20 Thread Oleh Prypin
New submission from Oleh Prypin : I was just looking at documentation of https://docs.python.org/3.6/library/subprocess.html#subprocess.run and thought that it doesn't support passing `env` because the list of supported keyword arguments is exhaustive (no **kwargs). But it does support passing