[issue31756] subprocess.run should alias universal_newlines to text

2017-10-22 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker ___

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 7fed7bd8bb628f0f09c6011871a4ce68afb41b18 by Gregory P. Smith (andyclegg) in branch 'master': bpo-31756: subprocess.run should alias universal_newlines to text (#4049) https://github.com/python/cpython/commit/7fed7bd8bb628f0f09c6011871a4ce68afb4

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-22 Thread Wolfgang Maier
Change by Wolfgang Maier : -- nosy: -wolma ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-22 Thread Wolfgang Maier
Change by Wolfgang Maier : -- nosy: +wolma ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-20 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mail

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-19 Thread Andrew Clegg
Change by Andrew Clegg : -- keywords: +patch pull_requests: +4018 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-11 Thread Nick Coghlan
Nick Coghlan added the comment: As far as docs phrasing goes, it probably makes sense to frame it as "text" being the preferred argument name in 3.7+, with "universal_newlines" retained indefinitely as a compatibility preserving alias. After all, if that wasn't our intention, we wouldn't be a

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-11 Thread Andrew Clegg
Andrew Clegg added the comment: OK great, I'll get working on a patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-11 Thread Steve Dower
Steve Dower added the comment: > just an alias Which I recognise is in the bug title. My point is that the enhancement itself is less relevant than the rationale and the documentation. Without a doc patch, there's really nothing to discuss here other than duplicating APIs (which is probably

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-11 Thread Steve Dower
Steve Dower added the comment: Really, this is just an alias for universal_newlines in Popen.__init__. So we add the parameter and: +if text: +universal_newlines = True self.universal_newlines = universal_newlines And 99% of the change is making it clear in the docs why we ha

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-11 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue31756] subprocess.run should alias universal_newlines to text

2017-10-11 Thread Andrew Clegg
New submission from Andrew Clegg : Following on from https://bugs.python.org/issue6135 The subprocess module by default returns bytes from subprocess calls. It has a text mode, but this can only be accessed by slightly tangential arguments (setting encoding, errors or universal_newlines). nco