[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset cae6e4775b37c412609d3a0d303c0831ff0012ff by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31655: Validate keyword names in SimpleNamespace constructor. (GH-3909) (#3920) https://github.com/python/cpython/commit/cae6e4775b3

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-07 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +3893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 79ba471488b936abda5ba5234b1ea90cbc94cae6 by Serhiy Storchaka in branch 'master': bpo-31655: Validate keyword names in SimpleNamespace constructor. (#3909) https://github.com/python/cpython/commit/79ba471488b936abda5ba5234b1ea90cbc94cae6 -

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- type: -> behavior versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +3881 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-06 Thread Terry J. Reedy
Terry J. Reedy added the comment: After reading the doc entry for SimpleNamespace, I see running 'SimpleNamespace(**{0:0})' as a bug because doing so results in an object than contradicts the doc. 1. "A simple object subclass that provides attribute access to its namespace, as well as a mean

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-02 Thread STINNER Victor
STINNER Victor added the comment: Please reject non-string keys. I don't see any good reason to use non-string, and it's painful to support such CPython implementation details in other Python implementations. -- versions: +Python 3.7 ___ Python tra

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-01 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Wouldn't be better to add also the check that keyword names > for SimpleNamespace constructor are strings? Yes. > I don't know how classify this issue, as a bug or an enhancement. It is arguably a bug fix. +0 for putting this in Python 3.6. --

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-01 Thread R. David Murray
R. David Murray added the comment: Sorry, not broken, it just raises a type error, which is appropriate :) -- ___ Python tracker ___ ___

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-01 Thread R. David Murray
Change by R. David Murray : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31655] SimpleNamespace accepts non-string keyword names

2017-10-01 Thread R. David Murray
R. David Murray added the comment: Well, it would be an "unenhancement" (reducing functionality :). What I think it would be classed as is an API bug fix, and those generally can be made only in feature releases. I can imagine code depending on this ability, since we have had code in the w

[issue31655] SimpleNamespace accepts non-string keyword names

2017-09-30 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Usually non-string keyword names are rejected. >>> def f(**kwargs): pass >>> >>>