[issue31650] implement PEP 552

STINNER Victor added the comment: New changeset 80b762f010097ab8137782e5fbdc89c5c620ed4e by Victor Stinner in branch 'master': bpo-31650: Remove _Py_CheckHashBasedPycsMode global config var (GH-8608) https://github.com/python/cpython/commit/80b762f010097ab8137782e5fbdc89c5c620ed4e -

[issue31650] implement PEP 552

Change by STINNER Victor : -- pull_requests: +8113 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31650] implement PEP 552

STINNER Victor added the comment: The test failed on s390x RHEL 3.x, PPC64 Fedora 3.x, s390x SLES 3.x, s390x Debian 3.x, s390x RHEL 3.x They are now all green, good! -- ___ Python tracker ___

[issue31650] implement PEP 552

Change by Benjamin Peterson : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue31650] implement PEP 552

Benjamin Peterson added the comment: Looks fine to me now? http://buildbot.python.org/all/#/builders/21 -- ___ Python tracker ___ __

[issue31650] implement PEP 552

STINNER Victor added the comment: Failure on Python on s390x RHEL 3.x: http://buildbot.python.org/all/#/builders/21/builds/340 == FAIL: test_source_hash (test.test_imp.ImportTests) -

[issue31650] implement PEP 552

Benjamin Peterson added the comment: New changeset 42aa93b8ff2f7879282b06efc73a31ec7785e602 by Benjamin Peterson in branch 'master': closes bpo-31650: PEP 552 (Deterministic pycs) implementation (#4575) https://github.com/python/cpython/commit/42aa93b8ff2f7879282b06efc73a31ec7785e602 ---

[issue31650] implement PEP 552

Benjamin Peterson added the comment: On Sat, Dec 9, 2017, at 01:06, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > While we are here, can other changes be made? All these suggestions seem fine, but they're not in the PEP and the change is already large enough. gps also

[issue31650] implement PEP 552

Serhiy Storchaka added the comment: While we are here, can other changes be made? 1. Increase the size of the constant part of the signature. Currently it is only 2 bytes (3rd and 4th bytes are b'\r\n') and it is hard to use them in tools like `file`. 2. Split the magic number on two parts.

[issue31650] implement PEP 552

Change by Benjamin Peterson : -- keywords: +patch pull_requests: +4503 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue31650] implement PEP 552

Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue31650] implement PEP 552

New submission from Benjamin Peterson : Now that PEP 552 is accepted, we'll need an actual implementation. Besides the core import changes, there are some perquisites improvements. For one, our SipHash implementation needs to be changed to accept an arbitrary key. Also, the PEP also introduces