[issue31569] inconsistent case of PCbuild/ directory

2017-09-25 Thread Steve Dower
Changes by Steve Dower : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue31569] inconsistent case of PCbuild/ directory

2017-09-25 Thread Paul Moore
Paul Moore added the comment: New changeset f1502d097c29b266a5748312ee2451a2d6ac0af6 by Paul Moore (Stefan Grönke) in branch 'master': bpo-31569: correct PCBuild/ case to PCbuild/ in build scripts and docs (GH-3711) https://github.com/python/cpython/commit/f1502d097c29b266a5748312ee2451a2d6ac0a

[issue31569] inconsistent case of PCbuild/ directory

2017-09-25 Thread Paul Moore
Paul Moore added the comment: OK, having re-read the PR, I'm fine with applying it as is, too. -- ___ Python tracker ___ ___ Python-b

[issue31569] inconsistent case of PCbuild/ directory

2017-09-25 Thread Zachary Ware
Zachary Ware added the comment: Personally, *I'd* prefer PC -> Windows and PCbuild -> Windows\build :) I'm also good with the PR as is. -- ___ Python tracker ___ __

[issue31569] inconsistent case of PCbuild/ directory

2017-09-25 Thread Steve Dower
Steve Dower added the comment: I'm okay with the PR as it stands, especially the parts that affect GitHub and appveyor, as those are almost certainly using case sensitive comparisons. It's definitely not easier to update the case of a file that is in git, and doing so will very likely break us

[issue31569] inconsistent case of PCbuild/ directory

2017-09-24 Thread Paul Moore
Paul Moore added the comment: I would strongly prefer the docs to be changed to match the implementation rather than the other way round. However, I don't see the use case for this - what case sensitive filesystem would anybody be building the Windows version of Python on? I'm -1 on changing

[issue31569] inconsistent case of PCbuild/ directory

2017-09-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Wouldn't be easier to make changes in the opposite direction? Change PCbuild to PCBuild? The file systems on Windows are case-insensitive, so this hardly an error. -- nosy: +serhiy.storchaka ___ Python tracker

[issue31569] inconsistent case of PCbuild/ directory

2017-09-24 Thread Stefan Grönke
New submission from Stefan Grönke: While reading the build documentation for Windows, I've noticed the `PCbuild/` directory to be mentioned with a different case than the directory in the repository (`PCBuild/` instead of `PCbuild/`). Every occasion of `PCBuild` should be replaced with `PCbuil