[issue31443] Possibly out of date C extension documentation

Changes by Stefan Krah : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker ___ ___

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: New changeset b1558a0368949714f5765702a8d83a2d163eaacf by Stefan Krah in branch 'master': bpo-31443: Update included code. (#3697) https://github.com/python/cpython/commit/b1558a0368949714f5765702a8d83a2d163eaacf -- _

[issue31443] Possibly out of date C extension documentation

Changes by Stefan Krah : -- pull_requests: +3681 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: New changeset ca72589bfabe2fd0e12eebfeb770b6c7a499b3e6 by Stefan Krah in branch 'master': bpo-31443: Formulate the type slot initialization rules in terms of C99. (#3688) https://github.com/python/cpython/commit/ca72589bfabe2fd0e12eebfeb770b6c7a499b3e6 -

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: Okay, thanks. I found that bz2module.c has also used direct initialization for ages. I'm going to commit the change. -- ___ Python tracker ___ __

[issue31443] Possibly out of date C extension documentation

Christoph Reiter added the comment: Building the following with gcc from msys2 (cygwin) worked fine here: https://bpaste.net/show/0cafd5fa8211 -- nosy: +lazka ___ Python tracker __

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: In fact, building _decimal should also fail on Cygwin if this were still an issue. -- ___ Python tracker ___ _

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: Erik, if you are interested in Cygwin, could you please check that xxmodule.c builds on Cygwin with the patch? You need to uncomment a couple of lines in setup.py to build 'xx'. -- ___ Python tracker

[issue31443] Possibly out of date C extension documentation

Changes by Stefan Krah : -- keywords: +patch pull_requests: +3678 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue31443] Possibly out of date C extension documentation

R. David Murray added the comment: We do not currently officially support cygwin. There are people working on getting it working again (and having a buildbot) so we can support it, so cygwin support is a goal, but not currently a requirement. I've nosied Erik Brey, who is one of the main peo

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: I've just asked on python-dev if Cygwin is still broken. Not sure if we support it. -- ___ Python tracker ___

[issue31443] Possibly out of date C extension documentation

Christian Heimes added the comment: Do we still support cygwin? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: Thanks, Christian. -- I found that in the docs the culprit is Cygwin: db6a569de7ae595ada53b618fce6bbbd1c98d350 -- ___ Python tracker ___ _

[issue31443] Possibly out of date C extension documentation

Christian Heimes added the comment: I think it's svnmerge of this commit, which talks about VS 2005. It might have been required to support VS 2003 and 2005. ``` r59290 | christian.heimes | 2007-12-03 14:47:29 +0100 (Mon, 03 Dec 2007) | 3 lines Applied my patch #1455 with some extra fixes

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: Christian, do you remember which compiler was the reason for the commit cbf3b5cb76906fba15dbf59a1e83c540a447b907 ? + /* Due to cross platform compiler issues the slots must be filled +* here. It's required for portability to Windows without requiring

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: FWIW, I've been using https://github.com/python/cpython/blob/master/Modules/_decimal/_decimal.c#L689 the static initialization on problematic platforms like Windows and AIX for years, without any problems. I'm sure this is valid C, and people here agree: htt

[issue31443] Possibly out of date C extension documentation

Stefan Krah added the comment: PyType_GenericNew() should be in libpython, so indeed the example in the docs seems a bit odd to me. -- nosy: +skrah ___ Python tracker ___ _

[issue31443] Possibly out of date C extension documentation

Romuald Brunet added the comment: I'm not sure this is relevant, but I've just made a simple test on Windows (7) with my C extension using { … .tp_new = PyType_GenericNew } and the compiler did not complain (also the code worked as expected) -- ___

[issue31443] Possibly out of date C extension documentation

Amaury Forgeot d'Arc added the comment: On Windows at least: I think "another C module" should be understood as "another DLL or executable". A user extension module is a different DLL from the core Python, so the advice is still valid. -- nosy: +amaury.forgeotdarc ___

[issue31443] Possibly out of date C extension documentation

New submission from Romuald Brunet: In the "Defining New Types documentation" basics about tp_new -> PyType_GenericNew, the doc states: > We’d like to just assign this to the tp_new slot, but we can’t, for > portability sake, On some platforms or compilers, we can’t statically > initialize a st