[issue30624] selectors should use bare except clauses

2017-06-12 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: I see that on 3.6 except BaseException: is used, so the backport should not be necessary. -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed versions: -Python 3.5, Python 3.6 ___ P

[issue30624] selectors should use bare except clauses

2017-06-12 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: New changeset ced36a993fcfd1c76637119d31c03156a8772e11 by Giampaolo Rodola in branch 'master': bpo-30624 remaining bare except (#2108) https://github.com/python/cpython/commit/ced36a993fcfd1c76637119d31c03156a8772e11 -- ___

[issue30624] selectors should use bare except clauses

2017-06-11 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > But only 2 of 3 "except Exception" are fixed. My bad. New PR: https://github.com/python/cpython/pull/2108 -- ___ Python tracker ___ __

[issue30624] selectors should use bare except clauses

2017-06-11 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- pull_requests: +2161 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue30624] selectors should use bare except clauses

2017-06-11 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: My apologies. The Misc/NEWS entry is correct. But only 2 of 3 "except Exception" are fixed. -- ___ Python tracker ___ ___

[issue30624] selectors should use bare except clauses

2017-06-11 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka added the comment: Look also at KqueueSelector.modify(). And the mentioning of SystemError in Misc/NEWS is wrong, it is a subclass of Exception. I guess that he means SystemExit ;-) -- ___ Python tr

[issue30624] selectors should use bare except clauses

2017-06-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Look also at KqueueSelector.modify(). And the mentioning of SystemError in Misc/NEWS is wrong, it is a subclass of Exception. -- ___ Python tracker _

[issue30624] selectors should use bare except clauses

2017-06-10 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: I removed 3.4 from versions, since this is not a security fix. Does this need backport to 3.5 too? Or only 3.6? -- nosy: +Mariatta stage: -> backport needed versions: -Python 3.4 ___ Python tracker

[issue30624] selectors should use bare except clauses

2017-06-10 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- pull_requests: +2146 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue30624] selectors should use bare except clauses

2017-06-10 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola': Right now it uses "except Exception: ...; raise" which does not take KeyboardInterrupt and SystemExit into account, leaving the fd in a bad state (it's not unregister()ed). -- components: asyncio messages: 295648 nosy: berker.peksag, giampaolo.rod