[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Changes by Matt Joiner : -- nosy: +anacrolix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: I added an additional invalid test which David pointed out and made changes to invalid url checking code. I moved it more higher level. - The reason for doing this is, invalid url test code (which is very specific for '[' enclosed ']' ipv6 url is concentrate

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

R. David Murray added the comment: I don't know how deep you want to get into detecting invalid URIs, but with the new patch this one causes a parsing error that is probably worth dealing with: http://abc[xyz]jkl Maybe a reasonable set of checks would be (in hostname) that if the part of th

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: Moving the Bad URL check to a higher level can be detect the bad urls much better. Once I the netloc is parsed and obtained, invalid URL can be checked. I am attaching an update with the new test included. If you have any comments, please let me know. --

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

R. David Murray added the comment: I posted this to the checkins list, but for reference, the following invalid URL should be added to the test cases: http://[::1/foo/bar]/bad -- nosy: +r.david.murray ___ Python tracker

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: Reverted the check-in made to 3.1 maint (in r80104). Features should not go in there. -- ___ Python tracker ___ __

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: merged into py3k in revision 80102 and release31-maint in revision 80103. Thanks for the patches, Tony and Hans. I have acknowledged it in NEWS file too. -- resolution: accepted -> fixed stage: patch review -> committed/rejected status: open -> closed

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: Committed into trunk in revision 80101 -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Benjamin Peterson added the comment: This is ok with me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: Final patch with inclusion of detecting invalid urls at netloc and hostname level, tests and NEWS entry. -- Added file: http://bugs.python.org/file16931/issue2987-final.patch ___ Python tracker

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: Actually, this bug is just for parsing the IPv6 url. We are having the right set of patches in the bug. I shall commit it soon. The RFC part is separate and we will slowly achieve a good compliance with STD 66. -- _

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Éric Araujo added the comment: Hello Thanks for the precision. This particular topic is discussed on #5650, feel free to help there! Better update the code before the doc, though. Regards -- ___ Python tracker

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Keegan Carruthers-Smith added the comment: Just thought I'd point out that RFC2732 was obsoleted by RFC3986 http://www.rfc-editor.org/rfc/rfc3986.txt -- nosy: +Keegan.Carruthers-Smith ___ Python tracker __

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: After spending a sufficient amount of time looking at patches and the RFC 2732, I tend to agree with the patch provided by tlocke. It does cover the behavior for parsing IPv6 URL with '[' hostname ']'. RFC 2732 is very short and just says that hostname in th

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Senthil Kumaran added the comment: With respect to msg98314 (http://bugs.python.org/msg98314) referenced in this bug, which I thought is easy to handle, does not appear so. It is bit tricky. The problem is the relative url is given of the format '07.11.2009-9:54:12-1.jpg' and urlparse wrongly

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Changes by Antoine Pitrou : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Tony Locke added the comment: Regarding the RFC list issue, I've posted a new patch with a new RFC list that combines ndim's list and the comments from #5650. Pitrou argues that http://dead:beef::]/foo/ should fail because it's a malformed URL. My response would be that the parse() function h

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Changes by Tony Locke : Removed file: http://bugs.python.org/file16886/parse.py.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue2987] RFC2732 support for urlparse (IPv6 addresses)

Antoine Pitrou added the comment: > Isn’t “http://dead:beef::]/foo/“ and invalid URI? That's the point, it shouldn't parse as a valid one IMO. -- title: RFC2732 support for urlparse (e.g. http:// -> RFC2732 support for urlparse (IPv6 addresses) ___