[issue2975] VS8 include dirs grow without bound

Scott Dial added the comment: I was looking through old issues I had commented on and saw that my patch was never applied. The current tip of the codebase still has the redundant "removeDuplicates" function. Not a big deal, just a little extra noise in the code. Probably not worth opening a n

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Yes, much better. I should have read into the interior of the discussion rather than just the edges... Thanks! ___ Python tracker <[EMAIL PROTECTED]> _

[issue2975] VS8 include dirs grow without bound

Scott Dial <[EMAIL PROTECTED]> added the comment: This patch shouldn't have been applied as it is. The definition of "removeDuplicates" is both poorly-named, not exactly correct, and redundant (as there is already a "normalize_and_reduce_paths") for performing this fix on PATH. Jim, you acknowl

[issue2975] VS8 include dirs grow without bound

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Applied both patches (a bit differently for the equal sign) as r66171. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Any hope for these two patches being applied? ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Here is the equals sign fix as a separate patch file. Added file: http://bugs.python.org/file11343/equalsInEnv.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Sorry, posted too quickly. Actually, the problem was a little different. There was an environment variable with '=' characters in it. Here is a patch to deal with that: --- msvc9compiler.py.orig 2008-07-23 16:13:25.248438400 -0700 +++ m

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Any new thoughts on this? I had to patch my local copy again after a reinstall. It would be nice to fix it upstream. ___ Python tracker <[EMAIL PROTECTED]>

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Actually, now that I think about it a little more, it seems like "very bad practice" to change the process environment variables as a side effect. A better solution would be to keep a variable for the required ones that is modified as necessary

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: In this file: http://svn.python.org/view/python/trunk/Lib/distutils/msvc9compiler.py?rev=62636&view=auto Notice the line containing: os.environ['include'] = vc_env['include'] This causes the process environment variables to acquire the valu

[issue2975] VS8 include dirs grow without bound

Scott Dial <[EMAIL PROTECTED]> added the comment: The path gets changed everytime a MSVCCompiler is instantiated. I've seen the same problem with PATH before with PyPy. I agree this is a bug, but I don't see how it can be fixed. The problem exists inside of vcvarsall.bat if I understand this corr

[issue2975] VS8 include dirs grow without bound

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: I don't understand where the problem comes from: query_vcvarsall() is called only once, when the distutils.msvc9compiler module is imported. Or is the module somehow reloaded or removed from sys.modules? -- nosy: +amaury.forgeot

[issue2975] VS8 include dirs grow without bound

Jim Kleckner <[EMAIL PROTECTED]> added the comment: Talk about tunnel vision... The code is right next to it! It is the include paths that are growing without bound (and presumably the LIBPATH as well). The test case is the Cython unit tests. They run until the include variable generates a "l

[issue2975] VS8 include dirs grow without bound

Scott Dial <[EMAIL PROTECTED]> added the comment: I don't believe this is a valid bug. Can you provide a case where it does in fact grow? This issue has previously been addressed in #1685563, and was carried over to the new code as well. Some lines after the path is appended to, there is a call