[issue29734] os.stat handle leak

Berker Peksag added the comment: New changeset 6ef726af3ec106013c7c4261ddb306854f2b1778 by Berker Peksag in branch 'master': bpo-29734: Cleanup test_getfinalpathname_handles test (GH-12908) https://github.com/python/cpython/commit/6ef726af3ec106013c7c4261ddb306854f2b1778 -- nosy: +b

[issue29734] os.stat handle leak

Change by Berker Peksag : -- pull_requests: +12835 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue29734] os.stat handle leak

miss-islington added the comment: New changeset 63a69ef4a2390cea3e102498ac7eeeb5546e82b6 by Miss Islington (bot) in branch '3.7': bpo-29734: nt._getfinalpathname handle leak (GH-740) https://github.com/python/cpython/commit/63a69ef4a2390cea3e102498ac7eeeb5546e82b6 -- nosy: +miss-isl

[issue29734] os.stat handle leak

Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue29734] os.stat handle leak

Steve Dower added the comment: New changeset b82bfac4369c0429e562a834b3752e66c4821eab by Steve Dower (Mark Becwar) in branch 'master': bpo-29734: nt._getfinalpathname handle leak (GH-740) https://github.com/python/cpython/commit/b82bfac4369c0429e562a834b3752e66c4821eab -- _

[issue29734] os.stat handle leak

Change by miss-islington : -- keywords: +patch, patch pull_requests: +11652, 11653 ___ Python tracker ___ ___ Python-bugs-list maili

[issue29734] os.stat handle leak

Steve Dower added the comment: We certainly shouldn't be calling CloseHandle on a parameter like this anyway, so the change looks good to me. However, I notice that we don't necessarily preserve GetLastError() throughout here, so perhaps we ought to consider changing the return value interpr

[issue29734] os.stat handle leak

Eryk Sun added the comment: Steve, can you review and merge PR 740? Mark updated it to fix the handle leaks in win32_xstat_impl as mentioned in my previous message. They're unlikely but still should be fixed. In particular, iIt's unlikely that win32_get_reparse_tag (i.e. FSCTL_GET_REPARSE_PO

[issue29734] os.stat handle leak

Eryk Sun added the comment: The os__getfinalpathname_impl handle leak and VOLUME_NAME_NT problems were fixed in another issue. However, PR 740 also includes fixes for handle leaks in os.stat, specifically in win32_xstat_impl and get_target_path. -- stage: -> patch review title: nt._