[issue29442] Replace optparse with argparse in setup.py

STINNER Victor added the comment: > bpo-29442: Replace optparse with argparse in setup.py (GH-139) I'm surprised that it works, but I tested manually and I confirm that it works :-) $ git clean -fdx $ ./configure --with-pydebug $ make $ ./python -c "import select" No compilation error ;-)

[issue29442] Replace optparse with argparse in setup.py

Change by INADA Naoki : -- nosy: -inada.naoki resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.7 ___ Python tracker ___

[issue29442] Replace optparse with argparse in setup.py

INADA Naoki added the comment: New changeset 09b2bece78f62c3d363236dce593ecfe130afd2f by INADA Naoki (Chih-Hsuan Yen) in branch 'master': bpo-29442: Replace optparse with argparse in setup.py (GH-139) https://github.com/python/cpython/commit/09b2bece78f62c3d363236dce593ecfe130afd2f

[issue29442] Replace optparse with argparse in setup.py

Chi Hsuan Yen added the comment: Thanks to Serhiy Storchaka's work in issue 30152, this patch can be simplified. I've rebased my branch and updated the pull request. -- ___ Python tracker

[issue29442] Replace optparse with argparse in setup.py

STINNER Victor added the comment: I consider that the issue #30152 is now a dependency of this change. -- dependencies: +Reduce the number of imports for argparse ___ Python tracker

[issue29442] Replace optparse with argparse in setup.py

Serhiy Storchaka added the comment: See also issue30152. It includes Chi's change for argparse (actually it was inspired by Chi's change) and much more. -- stage: resolved -> patch review ___ Python tracker __

[issue29442] Replace optparse with argparse in setup.py

Chi Hsuan Yen added the comment: I guess you were asking whether the newly compiled Python binary is able to build extension modules or not? I rebased PR 139 against the latest git master and seems it's fine. Running `make distclean`, `./configure` and then `make` builds all modules as expecte

[issue29442] Replace optparse with argparse in setup.py

STINNER Victor added the comment: Did someone test the patch? Does Python still bootstrap after a distclean or not? If not, I suggest to close the issue, except if Chi Hsuan Yen finf an elegant way to fix them :-) -- ___ Python tracker

[issue29442] Replace optparse with argparse in setup.py

Brett Cannon added the comment: I just wanted to acknowledge that I read this thread. I accept Chi's acknowledgement of his actions and I hope there aren't future missteps, but please also realize that there has been a warning about how you communicate here, Chi. -- _

[issue29442] Replace optparse with argparse in setup.py

Serhiy Storchaka added the comment: > (example: usage of os.system() in some places) See similar issue7438. -- ___ Python tracker ___ ___

[issue29442] Replace optparse with argparse in setup.py

Chi Hsuan Yen added the comment: I see your points. Indeed in many times I didn't think carefully before leaving a comment, and not even noticing that my comments can be offensive afterwards. I apologize for all those cases and I'll be more careful when interacting with others in the future.