[issue29013] zipfile: inconsistent doc for ZIP64 file size

2018-09-21 Thread Monte Davidoff
Monte Davidoff added the comment: I agree it may be better if we don't describe all the details of ZIP64. How about this rewording for the second change, so we don't have to give all the details? (2) In the description of the zipfile.ZipFile class, change: "If allowZip64 is True (the defaul

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2018-09-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This would look good too. To be accurate, zipfile will create ZIP files that use the ZIP64 extensions when: * It contains more than 65535 files. * It is larger than 2 GiB. More accurate, when either the offset or the size of the central directory is larg

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2018-09-20 Thread Monte Davidoff
Monte Davidoff added the comment: Serhiy, merely reverting the change would not fix the originally reported problem in the documentation. Based on your additional information, and to prevent the need to describe the ZIP64 extensions in more than one place, I suggest two changes: (1) Change

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2018-09-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think we should just revert this. The zipfile module can handle ZIP files up to 4 GiB without the ZIP64 extensions, but it requires the ZIP64 extensions for creating ZIP files larger than 2 GiB. The ZIP64 extensions is required also for ZIP files with mo

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-02 Thread Berker Peksag
Berker Peksag added the comment: Right, that's my fault. Apparently I missed the "[...] zipfile will create [...]" part :) What do you think about Monte's suggested changes Serhiy? Should we just revert 4685cd33087b (1) or do both (1) and (2)? -- stage: -> needs patch ___

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-02 Thread Monte Davidoff
Monte Davidoff added the comment: Serhiy, thank you for the correction and the additional information. I tried reading a zip file larger than 4 GiB with allowZip64=False, and it worked, so it looks like allowZip64 only applies to writing. I suggest we fix the inconsistency in the documentation

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-01 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The documentation was correct. The zipfile module supports *reading* ZIP files up to 4 GiB without the ZIP64 extension, but it requires allowZip64=True for *writing* over 2 GiB files to the ZIP file. The 2 GiB limit is safer because generated ZIP files can b

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4685cd33087b by Berker Peksag in branch '3.5': Issue #29013: Fix allowZip64 documentation https://hg.python.org/cpython/rev/4685cd33087b New changeset 7c5075a14459 by Berker Peksag in branch '3.6': Issue #29013: Merge from 3.5 https://hg.python.org/

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the analysis, Monte! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.6, Python 3.7 ___ Python tracker

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2016-12-19 Thread Monte Davidoff
New submission from Monte Davidoff: The documentation for the zipfile module, https://docs.python.org/3.5/library/zipfile.html, contains inconsistent descriptions of the maximum size of a ZIP file when allowZip64 is False. The second paragraph in the zipfile module documentation states: "It c