[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Py

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Roundup Robot added the comment: New changeset 56a7eb5a0679 by Xiang Zhang in branch '3.6': Issue #28930: Add a Makefile rule for bytes_methods.c. https://hg.python.org/cpython/rev/56a7eb5a0679 New changeset c4bcca326c0a by Xiang Zhang in branch 'default': Issue #28930: Merge from 3.6. https://h

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

STINNER Victor added the comment: LGTM, you can push it to 3.6 and default. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Serhiy Storchaka added the comment: Makefile-bytes-methods-v2.patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Xiang Zhang added the comment: > Alternatively just BYTESTR_DEPS can be used instead of BYTESMETHODS_DEPS. > This would make easier moving implementations between bytesobject.c and > bytes_methods.c. Yes. The only downside of this is some changes may recompile bytes_methods.c unnecessarily bu

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Serhiy Storchaka added the comment: LGTM. But be aware of possible differences in 3.5. Alternatively just BYTESTR_DEPS can be used instead of BYTESMETHODS_DEPS. This would make easier moving implementations between bytesobject.c and bytes_methods.c. -- ___

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Changes by Xiang Zhang : -- assignee: -> xiang.zhang keywords: +patch stage: needs patch -> patch review type: behavior -> versions: +Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file45829/Makefile-bytes-methods.patch ___ Py

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

Serhiy Storchaka added the comment: Needed a rule in Makefile. -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___ __

[issue28930] bytes_methods.c won't recompile if related stringlib/* changed

New submission from Xiang Zhang: bytes_methods.c includes files in stringlib, for example, stringlib/count.h. But if count.h changes, simply running make won't recompile bytes_methods.c and the methods of bytes remain unchanged. You have to make distclean and compile from scratch. --