[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb830f1511ef by Serhiy Storchaka in branch '2.7': Issue #28925: cPickle now correctly propagates errors when unpickle instances https://hg.python.org/cpython/rev/eb830f1511ef -- nosy: +python-dev ___ Pyth

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps it was added for debugging. Exceptions that don't define own __new__ and __init__ inherit them from BaseException. BaseException constructor saves positional arguments as the args attribute. But not all standard exceptions accept arbitrary number of

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-15 Thread Raoul Gough
Raoul Gough added the comment: Hi Serhiy, thanks very much for looking at this. My only concern with removing the code completely is that it does work (presumably as intended) with at least some of the standard exception types. For example, if you change the demo to raise and catch a RuntimeEr

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think it is better to remove this code. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file45841/load_classic_instance_error-2.7.patch ___ Python tracker

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-09 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___

[issue28925] Confusing exception from cPickle on reduce failure

2016-12-09 Thread Raoul Gough
New submission from Raoul Gough: Description === Running the attached example program with Python 2.7.12 produces the output below. The demo deliberately raises a user-defined exception during the unpickling process, but the problem is that this exception does not propagate out of the