[issue2876] Write UserDict fixer for 2to3

Brett Cannon added the comment: Closing since 2.7 is already out the door. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ _

[issue2876] Write UserDict fixer for 2to3

Changes by Éric Araujo : -- superseder: patch to fix_import: UserDict -> collections -> ___ Python tracker ___ ___ Python-bugs-list ma

[issue2876] Write UserDict fixer for 2to3

Changes by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue2876] Write UserDict fixer for 2to3

Changes by Martin v. Löwis : -- components: +2to3 (2.x to 3.0 conversion tool) -Library (Lib) ___ Python tracker ___ ___ Python-bugs-li

[issue2876] Write UserDict fixer for 2to3

R. David Murray added the comment: Converting DictMixin to collections.MutableMapping is not necessarily a complete solution. MutableMapping does not provide all the methods that DictMixin does. See for example the problems encountered in issue 7975. -- nosy: +r.david.murray __

[issue2876] Write UserDict fixer for 2to3

Raymond Hettinger added the comment: UserDict.DictMixin needs to convert to collections.MutableMapping -- ___ Python tracker ___ ___ P

[issue2876] Write UserDict fixer for 2to3

Jeroen Ruigrok van der Werven added the comment: What's the consensus on this? I ask since I actually ran into code today that uses DictMixin and as such wasn't converted by the 2to3 tool. -- nosy: +asmodai ___ Python tracker

[issue2876] Write UserDict fixer for 2to3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Also, I believe the variable initializations at the beginning of the transform method are unneeded. ___ Python tracker <[EMAIL PROTECTED]> _

[issue2876] Write UserDict fixer for 2to3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: The patch looks very good over all. However, I'm not completely sure that 2to3 needs to give a warning on UserDict.UserDict instances. Wouldn't it be better to handle that with a py3k warning in UserDict? __

[issue2876] Write UserDict fixer for 2to3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- assignee: -> benjamin.peterson nosy: +benjamin.peterson ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: Could somebody else take a look at this and check in it if it looks alright? I think that it works currently but I can't check it in... ___ Python tracker <[EMAIL PROTECTED]> _

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: Here is a fixer and test suite for the UserDict. It doesn't do a very good job handling imports with 'as' right now, but it's core functionality appears to be working. If I get a chance I will improve its handling of 'as' cases at some point in the

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: I have the functionality for this working, and will post it tomorrow when I complete its test suite. ___ Python tracker <[EMAIL PROTECTED]>

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: Sorry about the delay with this. I've finally found some time to work on this, so it should be completed within the next couple of days. ___ Python tracker <[EMAIL PROTECTED]>

[issue2876] Write UserDict fixer for 2to3

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: I still don't see why this is a release blocker. Adding a 2to3 fixer certainly isn't a release blocker - if the fixer isn't available, users would need to manually fix the code. Adding a Py3k warning shouldn't be a release blocker, either -

[issue2876] Write UserDict fixer for 2to3

Changes by Barry A. Warsaw <[EMAIL PROTECTED]>: -- priority: deferred blocker -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2876] Write UserDict fixer for 2to3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: release blocker -> deferred blocker ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: On Sun, Aug 24, 2008 at 3:00 PM, Nick Edds <[EMAIL PROTECTED]> wrote: > > Nick Edds <[EMAIL PROTECTED]> added the comment: > > How soon is this needed by? I probably won't have a chance to do it in > the next week, but it shouldn't take that lon

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: How soon is this needed by? I probably won't have a chance to do it in the next week, but it shouldn't take that long to make once I get a chance to work on it. ___ Python tracker <[EMAIL PROTECTED]>

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: You know what, Nick, go for the fixer. UserDict.UserDict will need a deprecation warning, but otherwise a fixer for IterableUserDict and DictMixin is fine. And I can handle the deprecation if you want. -- assignee: collinwinter -> __

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: As I said, it isn't using the import filter, it's whether this should be done through a warning instead because the superclasses have changed. I really should ask on python-dev about this. -- priority: high -> release blocker

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: I've been thinking about this a bit, and I don't see how handling it should be all that different from handling module renaming. For import UserDict, we can just change UserDict to collections and deal with UserDict.UserDict with a deprecation wa

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: Ahh right. I totally forgot that there was already a fix_dict.py that took care of that. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: On Mon, Aug 18, 2008 at 10:59 AM, Nick Edds <[EMAIL PROTECTED]> wrote: > > Nick Edds <[EMAIL PROTECTED]> added the comment: > > What's the current status of this? I think it is waiting for someone to work on it. > If nobody is working on it, I

[issue2876] Write UserDict fixer for 2to3

Nick Edds <[EMAIL PROTECTED]> added the comment: What's the current status of this? If nobody is working on it, I would be willing to give it a shot. Can somebody just confirm that I have a correct understanding of the problem. UserDict.UserDict needs a deprecation warning, UserDict.IterableUserD

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: There is a possible patch in issue2046. -- superseder: -> patch to fix_import: UserDict -> collections ___ Python tracker <[EMAIL PROTECTED]> _

[issue2876] Write UserDict fixer for 2to3

Collin Winter <[EMAIL PROTECTED]> added the comment: It's doable, but there's no existing support similar to what fix_imports provides. I won't have time to work on this for the foreseeable future, but if someone is interested in working on this, I'd add this challenge: implement this in a way t

[issue2876] Write UserDict fixer for 2to3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: release blocker -> high ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Py

[issue2876] Write UserDict fixer for 2to3

Changes by Raymond Hettinger <[EMAIL PROTECTED]>: -- assignee: rhettinger -> brett.cannon __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list

[issue2876] Write UserDict fixer for 2to3

Raymond Hettinger <[EMAIL PROTECTED]> added the comment: UserDict.UserDict is gone. UserDict.IterableUserDict class is now collections.UserDict. UserDict.Mixin is now collections.MutableMapping. The new classes comform to the new dict API, so they fixer needs to also make same method adaptatati

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: Raymond, can you tell me exactly where each module-level thing in UserDict went and if it was renamed or not? That way the fixer can get written. -- assignee: -> rhettinger __ Tracker <[EMAIL PROTECTED

[issue2876] Write UserDict fixer for 2to3

Brett Cannon <[EMAIL PROTECTED]> added the comment: The that needs to be added to 2to3. -- status: closed -> open title: Backport UserDict move in 3.0 -> Write UserDict fixer for 2to3 __ Tracker <[EMAIL PROTECTED]> _