[issue28494] is_zipfile false positives

miss-islington added the comment: New changeset 7acb22e6e9061f85988c0c6c5ee25ebdf2950841 by Miss Islington (bot) in branch '3.8': bpo-28494: install ziptestdata to fix install bot (GH-15902) https://github.com/python/cpython/commit/7acb22e6e9061f85988c0c6c5ee25ebdf2950841 -- __

[issue28494] is_zipfile false positives

Change by miss-islington : -- pull_requests: +15553 pull_request: https://github.com/python/cpython/pull/15912 ___ Python tracker ___ __

[issue28494] is_zipfile false positives

Gregory P. Smith added the comment: New changeset c37447481ec8f6d0e49d0587ec0de3f9e7d56b28 by Gregory P. Smith in branch 'master': bpo-28494: install ziptestdata to fix install bot (GH-15902) https://github.com/python/cpython/commit/c37447481ec8f6d0e49d0587ec0de3f9e7d56b28 -- _

[issue28494] is_zipfile false positives

Change by Gregory P. Smith : -- pull_requests: +15543 pull_request: https://github.com/python/cpython/pull/15902 ___ Python tracker ___

[issue28494] is_zipfile false positives

miss-islington added the comment: New changeset 74b0291b03db60dd244d31e9c97407cccb8d30dd by Miss Islington (bot) in branch '3.8': bpo-28494: Test existing zipfile working behavior. (GH-15853) https://github.com/python/cpython/commit/74b0291b03db60dd244d31e9c97407cccb8d30dd -- nosy:

[issue28494] is_zipfile false positives

STINNER Victor added the comment: > The new ziptestdata/ subdir appears to not be part of the install that make > install does. :/ It seems like Lib/test/eintrdata/ (for example) is installed using LIBSUBDIRS variable in Makefile.pre.in. Note: The Windows installer copies recursively Lib/te

[issue28494] is_zipfile false positives

Gregory P. Smith added the comment: The new ziptestdata/ subdir appears to not be part of the install that make install does. :/ -- ___ Python tracker ___ ___

[issue28494] is_zipfile false positives

STINNER Victor added the comment: x86 Gentoo Installed with X 3.x buildbot is unhappy: https://buildbot.python.org/all/#/builders/103/builds/3051 == ERROR: test_execute_zip2 (test.test_zipfile.TestExecutablePrependedZip)

[issue28494] is_zipfile false positives

Change by miss-islington : -- pull_requests: +15532 pull_request: https://github.com/python/cpython/pull/15891 ___ Python tracker ___ __

[issue28494] is_zipfile false positives

Thomas Wouters added the comment: New changeset 3f4db4a0bab073b768fae958e93288bd5d24eadd by T. Wouters (Gregory P. Smith) in branch 'master': bpo-28494: Test existing zipfile working behavior. (GH-15853) https://github.com/python/cpython/commit/3f4db4a0bab073b768fae958e93288bd5d24eadd -

[issue28494] is_zipfile false positives

Change by Gregory P. Smith : -- pull_requests: +15502 pull_request: https://github.com/python/cpython/pull/15853 ___ Python tracker ___

[issue28494] is_zipfile false positives

Gregory P. Smith added the comment: it's a bugfix, it seems reasonable for 3.7 to me. I agree that the previous is_zipfile check is too lenient. I'll follow up on jjolly's PR for any specific concerns I have with the implementation. -- assignee: serhiy.storchaka -> gregory.p.smith

[issue28494] is_zipfile false positives

Change by Gregory P. Smith : -- versions: +Python 3.8 -Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue28494] is_zipfile false positives

Change by Matthew Ryan : -- nosy: +mryan1539 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue28494] is_zipfile false positives

Change by John Jolly : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28494] is_zipfile false positives

John Jolly added the comment: Is there any chance that this will make it into 3.7 or is my reminder too late? -- ___ Python tracker ___

[issue28494] is_zipfile false positives

John Jolly added the comment: Fix submitted that evaluates the ECD structure and validates the first CD entry. The fix also handles empty zipfiles. IMO the purpose of this API is to *quickly* verify that the file is a valid zipfile. With this fix, the API only reads another 46 bytes of data (

[issue28494] is_zipfile false positives

Change by John Jolly : -- pull_requests: +4934 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue28494] is_zipfile false positives

Serhiy Storchaka added the comment: No, checking the first bytes of the file is not appropriate option. zipfile should support the Python zip application format [1]. I see two options: 1. Make is_zipfile() more strict that the ZipFile constructor. The later supports ZIP files with a data past

[issue28494] is_zipfile false positives

Thomas Waldmann added the comment: Well, if you have a better idea how to fix is_zipfile, go on. I even suggested an alternative, how about that? It is a miserable state when the is_zipfile function in the stdlib detects random crap as a zip file. -- _

[issue28494] is_zipfile false positives

Serhiy Storchaka added the comment: The problem is that the zipfile module supports even not well-formed archives, with a data appended past a comment, and with truncated comment. There are special tests for this, and the proposed patch breaks these tests: test_comments, test_ignores_newline_a

[issue28494] is_zipfile false positives

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28494] is_zipfile false positives

Thomas Waldmann added the comment: Note: checking the first bytes of the file (PK..) might be another option. But this has the "problem" that a self-extracting zip starts with an executable that has different first bytes. So whether this is an option or not depends on whether is_zipfile() shou

[issue28494] is_zipfile false positives

Thomas Waldmann added the comment: patch for py2.7 The EOCD structure is at EOF. It either does not contain a comment (this is what the existing code checks first) or it contains a comment of the length that is specified in the structure. The patch checks consistency specified length vs. rea

[issue28494] is_zipfile false positives

Changes by Serhiy Storchaka : -- nosy: +alanmcintyre, serhiy.storchaka, twouters versions: +Python 3.6, Python 3.7 ___ Python tracker ___

[issue28494] is_zipfile false positives

New submission from Thomas Waldmann: zipfile.is_zipfile has false positives way too easily. I just have seen it in practive when a MoinMoin wiki site with a lot of pdf attachments crashed with 500. This was caused by a valid PDF that just happened to contain PK\005\006 somewhere in the middle