[issue28484] test_capi, test_regrtest fail when multithreading disabled

2016-10-20 Thread Martin Panter
Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue28484] test_capi, test_regrtest fail when multithreading disabled

2016-10-20 Thread Roundup Robot
Roundup Robot added the comment: New changeset b811ec148337 by Martin Panter in branch '3.6': Issue #28484: Skip tests if GIL is not used or multithreading is disabled https://hg.python.org/cpython/rev/b811ec148337 -- nosy: +python-dev ___ Python trac

[issue28484] test_capi, test_regrtest fail when multithreading disabled

2016-10-20 Thread STINNER Victor
STINNER Victor added the comment: Each time I see a bug error on --without-treads, I want to remove the option. We had a buildbot in the past, but I don't see it anymore. mt-victor.patch LGTM except of a minor comment, see my review. -- ___ Python t

[issue28484] test_capi, test_regrtest fail when multithreading disabled

2016-10-20 Thread Martin Panter
New submission from Martin Panter: Two tests in test_capi assume that the GIL is always used, but I don’t think it is available when Python is built with “configure --without-threads”. So I propose to skip these tests if the “threading” module is unavailable. In test_regrtest, a test is rerun