[issue28335] Exception reporting in `logging.config`

Ram Rachum added the comment: Thanks for the quick fix Vinay! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28335] Exception reporting in `logging.config`

Roundup Robot added the comment: New changeset 8c005be54305 by Vinay Sajip in branch 'default': Issue #28335: made minor improvement to implementation. https://hg.python.org/cpython/rev/8c005be54305 -- ___ Python tracker

[issue28335] Exception reporting in `logging.config`

Roundup Robot added the comment: New changeset 69bf09bf4952 by Vinay Sajip in branch 'default': Closes #28335: used 'raise from' in logging configuration code. https://hg.python.org/cpython/rev/69bf09bf4952 -- nosy: +python-dev resolution: -> fixed stage: -> resolved status: open -> cl

[issue28335] Exception reporting in `logging.config`

Vinay Sajip added the comment: Patch as posted will not work (contains a syntax error), and was thus never tested. Never mind, I will address this soon. -- assignee: -> vinay.sajip ___ Python tracker

[issue28335] Exception reporting in `logging.config`

Ram Rachum added the comment: Thanks for the patch sreyas! Maybe we should also take this opportunity to remove the string formatting from the exception that shows the name of the original exception? Because when you think about it, it's just a poor man's `raise from`. -- ___

[issue28335] Exception reporting in `logging.config`

Changes by sreyas : -- keywords: +patch Added file: http://bugs.python.org/file44935/raisefrom.patch ___ Python tracker ___ ___ Python

[issue28335] Exception reporting in `logging.config`

Ram Rachum added the comment: You're right Vinay: I missed that first traceback because I wasn't running code in the console, I was running it with a debugger. (I'll ask my debugger vendor to maybe include these extra tracebacks.) But in any case, I think that the correct way to raise would be

[issue28335] Exception reporting in `logging.config`

Vinay Sajip added the comment: This is marked as relevant to Python 3.7, so I ran a test script using the latest Python sources: import logging import logging.config import sys def main(): config = { 'version': 1, 'formatters': { 'default': { '()

[issue28335] Exception reporting in `logging.config`

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28335] Exception reporting in `logging.config`

Ram Rachum added the comment: I now see similar raises that could use a `from` in other places in this module, so I'd suggest going over the module and putting `from`s all over the place. -- ___ Python tracker _

[issue28335] Exception reporting in `logging.config`

New submission from Ram Rachum: In `logging.config.DictConfigurator.configure`, there are exceptions that are caught and then replaced with `ValueError` exceptions. I think you should use the `raise x from y` syntax so that the original tracebacks will be preserved. (I'm debugging such an exce