[issue28257] Regression for star argument parameter error messages

Changes by Donald Stufft : -- pull_requests: +985 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28257] Regression for star argument parameter error messages

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___

[issue28257] Regression for star argument parameter error messages

Roundup Robot added the comment: New changeset 35676cd72352 by Serhiy Storchaka in branch '3.5': Issue #28257: Improved error message when pass a non-mapping as a var-keyword https://hg.python.org/cpython/rev/35676cd72352 -- ___ Python tracker

[issue28257] Regression for star argument parameter error messages

Serhiy Storchaka added the comment: Here is a patch with smaller (in comparison with issue27358) change for 3.5 that improves error message when pass a non-mapping as second var-keyword argument. Unpatched: >>> f(**{'a': 1}, **[]) Traceback (most recent call last): File "", line 1, in Type

[issue28257] Regression for star argument parameter error messages

Roundup Robot added the comment: New changeset 88b319dfc909 by Serhiy Storchaka in branch '3.6': Issue #28257: Improved error message when pass a non-iterable as https://hg.python.org/cpython/rev/88b319dfc909 New changeset bde594cd8369 by Serhiy Storchaka in branch 'default': Issue #28257: Impro

[issue28257] Regression for star argument parameter error messages

Serhiy Storchaka added the comment: Proposed patch fixes error message for var-positional arguments. It adds new opcode BUILD_TUPLE_UNPACK_WITH_CALL. >>> min(1, *2) Traceback (most recent call last): File "", line 1, in TypeError: min() argument after * must be an iterable, not int >>> min(*

[issue28257] Regression for star argument parameter error messages

Ned Deily added the comment: Raymond, Larry's comment was about 3.5, not 3.6. See my comment above. -- ___ Python tracker ___ ___ Pyt

[issue28257] Regression for star argument parameter error messages

Raymond Hettinger added the comment: > It's too late to change this for 3.5. The whole point of having a beta release is to detect issues like this. -- nosy: +rhettinger ___ Python tracker

[issue28257] Regression for star argument parameter error messages

Ned Deily added the comment: That is a fairly big change to go in now but the error message regression is also big. With a review from a core developer and assuming no other objections, I think this can go into 360b2. -- ___ Python tracker

[issue28257] Regression for star argument parameter error messages

Larry Hastings added the comment: It's too late to change this for 3.5. -- versions: -Python 3.5 ___ Python tracker ___ ___ Python-bu

[issue28257] Regression for star argument parameter error messages

Serhiy Storchaka added the comment: Ned and Larry. Is it allowed to use the patch from issue27358 for fixing a regression in 3.6 and inconsistency in 3.5 for var-keyword arguments? The patch introduces new private function _PyDict_MergeEx() and touches the implementation of PyDict_Merge(). Ma

[issue28257] Regression for star argument parameter error messages

Serhiy Storchaka added the comment: This is a consequence of issue27213. Actually there are two issues: with var-positional and var-keyword arguments. But Python 3.5 is not consistent. It raises an exception with less detailed message if there are multiple var-positional or var-keyword argumen

[issue28257] Regression for star argument parameter error messages

New submission from Kay Hayen: Hello, there is a regression in the beta (alpha 4 was ok) for this kind of code: print("Complex call with both invalid star list and star arguments:") try: a = 1 b = 2.0 functionWithDefaults(1,c = 3,*a,**b) except TypeError as e: print(repr(e))