[issue28131] assert statements missed when loaded by zipimporter

2017-03-31 Thread Donald Stufft
Changes by Donald Stufft : -- pull_requests: +887 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the reviews! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7bec326972f5 by Berker Peksag in branch '3.5': Issue #28131: Fix a regression in zipimport's compile_source() https://hg.python.org/cpython/rev/7bec326972f5 New changeset 7a6c0c4e6072 by Berker Peksag in branch '3.6': Issue #28131: Merge from 3.5 ht

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: lgtm -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch with a test case. -- keywords: +patch nosy: +berker.peksag stage: -> patch review type: -> behavior Added file: http://bugs.python.org/file44647/issue28131.diff ___ Python tracker

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Steve Dower
Changes by Steve Dower : -- nosy: +larry versions: +Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Steve Dower
Steve Dower added the comment: Bah, that's meant to be a -1 in that change, not 1. I must have typo'd when moving from the default branch to put it in 3.5. Anyone's welcome to fix it, or I'll get it when I have time for CPython work. -- ___ Python t

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Xiang Zhang
Xiang Zhang added the comment: This is introduced in 663a62bcf9c9. The compile optimize flag is opened in the change. -- nosy: +steve.dower, xiang.zhang ___ Python tracker ___ _

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: from the zip: >>> dis.dis(mod.test) 3 0 LOAD_GLOBAL 0 (print) 2 LOAD_FAST0 (val) 4 CALL_FUNCTION1 6 POP_TOP 8 LOAD_CONST 0 (None)

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Gregory P. Smith
Gregory P. Smith added the comment: This shouldn't be happening and makes no sense. It looks like the assert statement was removed at import code compilation time given the pdb trace with it from a zip file vs with it outside of a zip file: >>> pdb.run('mod.test(False)') > (1)() (Pdb) n Fals

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Brett Cannon
Brett Cannon added the comment: I've added Greg and Thomas in case they have any ideas as they have looked at zipimport more recently than I have. -- nosy: +gregory.p.smith, twouters ___ Python tracker ___

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Jason R. Coombs
New submission from Jason R. Coombs: Grabbing the recently released Python 3.6.0b1, I tried running one of my test suites, but found that some assertions were failing to assert when the package was loaded as a zip file (such as with pytest-runner installed dependencies). I distilled the issue