[issue28088] Document Transport.set_protocol and get_protocol

Guido van Rossum added the comment: Good point. Thanks Berker! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue28088] Document Transport.set_protocol and get_protocol

Changes by Berker Peksag : -- nosy: -larry priority: release blocker -> normal ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue28088] Document Transport.set_protocol and get_protocol

Berker Peksag added the comment: I just removed self from method signatures (we don't usually include it) and updated the versionadded directives to 3.5.3 since it was also backported to 3.5 in f12a59311885. Please let me know if got the 3.5 version wrong, thanks! -- nosy: +berker.peks

[issue28088] Document Transport.set_protocol and get_protocol

Roundup Robot added the comment: New changeset f4e86b1b051e by Berker Peksag in branch '3.5': Issue #28088: Don't include self in method signature https://hg.python.org/cpython/rev/f4e86b1b051e New changeset f2858945c058 by Berker Peksag in branch '3.6': Issue #28088: Merge from 3.5 https://hg.p

[issue28088] Document Transport.set_protocol and get_protocol

Roundup Robot added the comment: New changeset 3f5af4a25995 by INADA Naoki in branch '3.5': Issue #28088: Document Transport.set_protocol and get_protocol https://hg.python.org/cpython/rev/3f5af4a25995 New changeset a5e52b7be71f by INADA Naoki in branch '3.6': Issue #28088: Document Transport.se

[issue28088] Document Transport.set_protocol and get_protocol

Changes by INADA Naoki : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue28088] Document Transport.set_protocol and get_protocol

Guido van Rossum added the comment: LGTM too. Can someone add this to the asyncio docs (starting at the 3.5 branch please)? -- ___ Python tracker ___ ___

[issue28088] Document Transport.set_protocol and get_protocol

INADA Naoki added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue28088] Document Transport.set_protocol and get_protocol

Mariatta Wijaya added the comment: I added a note like this. .. note:: Switching protocol should only be done when both protocols are documented to support the switch. Would this work? Would appreciate any feedback of how to properly document this behavior. Thanks. -- Added

[issue28088] Document Transport.set_protocol and get_protocol

INADA Naoki added the comment: lgtm. But I think adding note like following may be helpful to avoid users try switching protocols which protocol author doesn't expect. (I'm not good English writer. I hope someone polish my sentence). .. note:: Generally speaking, switching protocols requir

[issue28088] Document Transport.set_protocol and get_protocol

New submission from Mariatta Wijaya: Added the documentation for set_protocol and get_protocol. -- keywords: +patch Added file: http://bugs.python.org/file44918/issue28088.patch ___ Python tracker _

[issue28088] Document Transport.set_protocol and get_protocol

Changes by Mariatta Wijaya : -- nosy: +Mariatta ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28088] Document Transport.set_protocol and get_protocol

Changes by Yury Selivanov : -- assignee: -> docs@python components: +Documentation nosy: +docs@python stage: -> needs patch type: -> enhancement ___ Python tracker ___ ___

[issue28088] Document Transport.set_protocol and get_protocol

Changes by Yury Selivanov : -- components: asyncio keywords: easy nosy: gvanrossum, haypo, ned.deily, yselivanov priority: release blocker severity: normal status: open title: Document Transport.set_protocol and get_protocol versions: Python 3.6 ___ P