[issue27860] Improvements to ipaddress module

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: New changeset f532fe5583d29d21e12aa22d8fca13e3bca94fb3 by Inada Naoki in branch '3.7': bpo-27860: ipaddress: fix Interface constructor (GH-14200) https://github.com/python/cpython/commit/f532fe5583d29d21e12aa22d8fca13e3bca94fb3 --

[issue27860] Improvements to ipaddress module

Change by Inada Naoki : -- pull_requests: +14038 pull_request: https://github.com/python/cpython/pull/14200 ___ Python tracker ___ _

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: OK, I thought I improved only undocumented behavior, but it was documented and previous behavior didn't follow the document. I'll backport PR 12836. -- ___ Python tracker

[issue27860] Improvements to ipaddress module

Change by Berker Peksag : -- nosy: -berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue27860] Improvements to ipaddress module

Jack added the comment: I for one have encountered #35990 in my work and would appreciate a backport. -- ___ Python tracker ___ ___

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: > I was wondering why it was decided against backporting to 3.7? Because I treats this is just a code cleanup. > 6fa84bd12c4b83bee6a41b989363230d5c03b96c fixes an actual bug #35990 (string > mask in tuple argument for IPv4Interfaces). I didn't thought it was a

[issue27860] Improvements to ipaddress module

Change by Jack : -- nosy: +Jacktose ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/m

[issue27860] Improvements to ipaddress module

SilentGhost added the comment: I was wondering why it was decided against backporting to 3.7? 6fa84bd12c4b83bee6a41b989363230d5c03b96c fixes an actual bug #35990 (string mask in tuple argument for IPv4Interfaces). Incidentally, there are also no tests for this behaviour. Just to note: both

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: I merged all cleanups. I don't merge accepting any IP representations as mask, because I'm not expert of this module. At least, I don't want to pass prefix/netmask by something like IPv4Network("0.0.255.255"). -- __

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: New changeset 6fa84bd12c4b83bee6a41b989363230d5c03b96c by Inada Naoki in branch 'master': bpo-27860: ipaddress: fix Interface missed some attributes (GH-12836) https://github.com/python/cpython/commit/6fa84bd12c4b83bee6a41b989363230d5c03b96c -- __

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: I am not owner of ipaddress module, so I don't know we should support more form of masks. On the other hand, IPv4Interface and IPv6Interface expose netmask and hostmask attributes when address is not bytes or int. These attributes are not documented. I assume i

[issue27860] Improvements to ipaddress module

Change by Inada Naoki : -- pull_requests: +12761 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: New changeset 2430d532e240dea55f0082d1e9bf2e0f3d7505be by Inada Naoki in branch 'master': bpo-27860: use cached_property (GH-12832) https://github.com/python/cpython/commit/2430d532e240dea55f0082d1e9bf2e0f3d7505be -- __

[issue27860] Improvements to ipaddress module

Change by Inada Naoki : -- pull_requests: +12757 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27860] Improvements to ipaddress module

Change by Inada Naoki : -- pull_requests: +12701 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27860] Improvements to ipaddress module

Inada Naoki added the comment: @moritzs Would you create a pull request on GitHub? Or may I create a pull request for your patch? -- nosy: +inada.naoki ___ Python tracker ___

[issue27860] Improvements to ipaddress module

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue27860] Improvements to ipaddress module

Changes by Serhiy Storchaka : -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue27860] Improvements to ipaddress module

Nick Coghlan added the comment: Peter, are you able to take a look at this or indicate you're happy for someone else to take it? (I relinquished my co-maintainer role for the ipaddress module a while back, so you're the only currently listed maintainer) --

[issue27860] Improvements to ipaddress module

Moritz Sichert added the comment: Any updates? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue27860] Improvements to ipaddress module

Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue27860] Improvements to ipaddress module

Changes by Serhiy Storchaka : -- nosy: +ncoghlan, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue27860] Improvements to ipaddress module

Changes by SilentGhost : -- nosy: +pmoody stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue27860] Improvements to ipaddress module

New submission from Moritz Sichert: This patch fixes the following minor issues with the ipaddress module: - Removed unused property _BaseV4._valid_mask_octets - Removed unused methods _BaseV4._is_valid_netmask() and _BaseV4._is_hostmask() - Replaced several calls to superclass constructors by s