[issue27842] Order CSV header fields

2016-08-30 Thread Steve Holden
Steve Holden added the comment: A pleasure. Pretty heavily committed at present, but all Python related so maybe there'll be more small positive improvements. -- ___ Python tracker

[issue27842] Order CSV header fields

2016-08-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks Steve. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-b

[issue27842] Order CSV header fields

2016-08-30 Thread Roundup Robot
Roundup Robot added the comment: New changeset bb3e2a5be31b by Raymond Hettinger in branch 'default': Issue #27842: The csv.DictReader now returns rows of type OrderedDict. https://hg.python.org/cpython/rev/bb3e2a5be31b -- nosy: +python-dev ___ Python

[issue27842] Order CSV header fields

2016-08-26 Thread Steve Holden
Steve Holden added the comment: OK, here's what I think should be close to the final patch. I've updated the documentation, rebuilt it and verified it reads OK, and confirmed that the new code passes all tests except those skipped for platform reasons (I think they expect a Windows environment

[issue27842] Order CSV header fields

2016-08-25 Thread Steve Holden
Steve Holden added the comment: Is there another way? :) Sent from my iPhone > On 26 Aug 2016, at 12:16, Raymond Hettinger wrote: > > > Raymond Hettinger added the comment: > > Consider using itertools.permutations() to generate the 120 cases cases. > > The news entry goes into Misc/NEWS (

[issue27842] Order CSV header fields

2016-08-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Consider using itertools.permutations() to generate the 120 cases cases. The news entry goes into Misc/NEWS (there is not .txt extension). -- ___ Python tracker __

[issue27842] Order CSV header fields

2016-08-24 Thread Steve Holden
Steve Holden added the comment: Testing could be interesting. I'm thinking of generating five random string keys with a couple of rows of data, creating csv StringIOs (using pure Python) for all 120 combinations and verifying that they read back in the order they were written. We should also

[issue27842] Order CSV header fields

2016-08-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: This looks like a nice improvement. The patch needs a test and the docs need a versionchanged entry. -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker _

[issue27842] Order CSV header fields

2016-08-23 Thread R. David Murray
R. David Murray added the comment: I think this seems reasonable, now that OrderedDict is in C. -- nosy: +r.david.murray type: -> enhancement ___ Python tracker ___

[issue27842] Order CSV header fields

2016-08-23 Thread R. David Murray
Changes by R. David Murray : -- hgrepos: -353 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue27842] Order CSV header fields

2016-08-23 Thread Steve Holden
Steve Holden added the comment: Sorry, deleted the originally submitted (incorrect) patch file. -- Added file: http://bugs.python.org/file44203/csv.patch ___ Python tracker ___ _

[issue27842] Order CSV header fields

2016-08-23 Thread Steve Holden
Changes by Steve Holden : Removed file: http://bugs.python.org/file44202/csv.patch ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue27842] Order CSV header fields

2016-08-23 Thread Steve Holden
New submission from Steve Holden: It's sometimes annoying that a csv.DictReader doesn't retain the field ordering given in the first line of the file. Sometimes it matters. This patch converts the reader so that it returns an OrderedDict rather than a plain dict, thereby retaining the ordering