[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Łukasz Langa added the comment: Barney, thanks for pushing this across the finish line! ✨ 🍰 ✨ And of course, Eryk for the report and original patch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.11 -Python 3.8 ___

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Łukasz Langa added the comment: New changeset debb751f11f5221eafcdf07a14c7e9408350ad9a by Miss Islington (bot) in branch '3.9': bpo-27827: identify a greater range of reserved filename on Windows. (GH-26698) (#27422) https://github.com/python/cpython/commit/debb751f11f5221eafcdf07a14c7e940835

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Łukasz Langa added the comment: New changeset 8789add99164177f29a8cd319a834187c65ab16c by Miss Islington (bot) in branch '3.10': bpo-27827: identify a greater range of reserved filename on Windows. (GH-26698) (GH-27421) https://github.com/python/cpython/commit/8789add99164177f29a8cd319a834187

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Change by miss-islington : -- pull_requests: +25950 pull_request: https://github.com/python/cpython/pull/27422 ___ Python tracker ___ __

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Łukasz Langa added the comment: New changeset 56c1f6d7edad454f382d3ecb8cdcff24ac898a50 by Barney Gale in branch 'main': bpo-27827: identify a greater range of reserved filename on Windows. (GH-26698) https://github.com/python/cpython/commit/56c1f6d7edad454f382d3ecb8cdcff24ac898a50 --

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +25949 pull_request: https://github.com/python/cpython/pull/27421 ___ Python tracker _

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Barney Gale added the comment: I've put Eryk's patch up as a PR: https://github.com/python/cpython/pull/26698 -- ___ Python tracker ___ ___

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Change by Barney Gale : -- nosy: +barneygale nosy_count: 6.0 -> 7.0 pull_requests: +25283 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26698 ___ Python tracker

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Change by Eryk Sun : -- stage: needs patch -> versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.5, Python 3.6 ___ Python tracker ___ ___

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

STINNER Victor added the comment: See also bpo-37517 "Improve error messages for Windows reserved file names". -- ___ Python tracker ___ __

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

STINNER Victor added the comment: See also bpo-36534 "tarfile: handling Windows (path) illegal characters in archive member names". -- nosy: +vstinner ___ Python tracker ___

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Serhiy Storchaka added the comment: Thanks for the estimation Eryk. Can you create a pull request for your patch? -- ___ Python tracker ___ __

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Eryk Sun added the comment: For COM[n] and LPT[n], only ASCII 1-9 and superscript 1-3 (U+00b9, U+00b2, and U+00b3) are handled as decimal digits. For example: >>> print(*(ascii(chr(c)) for c in range(1, 65536) ... if _getfullpathname('COM%s' % chr(c))[0] == '\\'), sep=', ') '1',

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Serhiy Storchaka added the comment: Are 'COM\u0661' or 'COM\u2074' reserved names? -- nosy: +serhiy.storchaka ___ Python tracker ___ _

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Eryk Sun added the comment: The attached patch adds tests and the suggested enhancement to _WindowsFlavour.is_reserved. Shouldn't it also return True if the name contains ASCII control characters? They're only valid in NTFS stream names. Also, I think a name containing a colon that's not par

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

Eryk Sun added the comment: Also, "CONIN$" and "CONOUT$" need to be added to the list of reserved names. Prior to Windows 8 these two names are reserved only for the current directory, which for the most part also applies to "CON". For Windows 8+, the redesign to use a real console device mea

[issue27827] pathlib is_reserved fails for some reserved paths on Windows

New submission from Eryk Sun: pathlib._WindowsFlavour.is_reserved assumes Windows uses an exact match up to the file extension for reserved DOS device names. However, this misses cases involving trailing spaces and colons, such as the following examples: Trailing colon: >>> pathlib.Path('