[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

Roundup Robot added the comment: New changeset 31e4495a34ce by Terry Jan Reedy in branch 'default': Issue #27787: No longer call deleted test_main(). https://hg.python.org/cpython/rev/31e4495a34ce -- ___ Python tracker

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

Changes by Martin Panter : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

Roundup Robot added the comment: New changeset 1f73355afebb by Martin Panter in branch 'default': Issue #27787: Remove test_main() and hard-coded list of test classes https://hg.python.org/cpython/rev/1f73355afebb -- ___ Python tracker

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

Martin Panter added the comment: I committed the gc_collect() change to 3.5 as well, because it helped me with a separate test case. Here is the remaining change, for 3.6 only. I added a timeout to the join() call. This matches the @reap_threads decorator, which times out after 1 s. -

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

Roundup Robot added the comment: New changeset 7ddbc2263943 by Martin Panter in branch '3.5': Issue #27787: Clean up weak references before checking for dangling threads https://hg.python.org/cpython/rev/7ddbc2263943 New changeset e5777c5d108c by Martin Panter in branch 'default': Issue #27787:

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

Martin Panter added the comment: Yes I agree it would make sense to separate the test_httplib changes from the general change. I thought this task would be a very easy change, and noticed it wasn’t that simple the last minute. I would like to adjust the cleanup call to self.addCleanup(thread.

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

STINNER Victor added the comment: Your patch changes 3 different things. After the code review, I suggest to split it in two changes (fix test_httplib threading ripper, fix save_env, fix test_httplib main). -- nosy: +haypo ___ Python tracker

[issue27787] Avoid test_main() in test_httplib; gc.collect() dangling threads

New submission from Martin Panter: In Issue 12319, there are many iterations of a patch that adds a new TestCase subclass to Lib/test/test_httplib.py. However it never got run by the main regrtest infrastructure, because nobody remembered to add the class to the list of test classes. So I want