[issue27533] release GIL in nt._isdir

Roundup Robot added the comment: New changeset ebf9a4c933e9 by Steve Dower in branch '3.5': Issue #27533: Release GIL in nt._isdir https://hg.python.org/cpython/rev/ebf9a4c933e9 New changeset 8823c660820e by Steve Dower in branch 'default': Issue #27533: Release GIL in nt._isdir https://hg.pytho

[issue27533] release GIL in nt._isdir

Changes by Steve Dower : -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue27533] release GIL in nt._isdir

R. David Murray added the comment: Correct, 2.7 is not in security fix only mode (yet), but new features (anything that changes an API) or bug fixes that we wouldn't put in a maintenance release (things that would break existing programs) are not allowed. A special exception has been made for

[issue27533] release GIL in nt._isdir

Steve Dower added the comment: Maybe so. If you find a core developer who cares about performance in 2.7, maybe they'll merge it :) -- ___ Python tracker ___ ___

[issue27533] release GIL in nt._isdir

Eryk Sun added the comment: OK. I thought fixing bugs in 2.7 was at the discretion of core developers, including small tweaks for performance -- just not enhancements with significant amounts of new code and features. -- ___ Python tracker

[issue27533] release GIL in nt._isdir

Steve Dower added the comment: No, it's not a security fix, so it doesn't go in 2.7. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue27533] release GIL in nt._isdir

Changes by Jeremy Spiegel : Added file: http://bugs.python.org/file43758/_isdir.2.7.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27533] release GIL in nt._isdir

Changes by Jeremy Spiegel : Removed file: http://bugs.python.org/file43757/_isdir.2.7.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue27533] release GIL in nt._isdir

Changes by Jeremy Spiegel : Added file: http://bugs.python.org/file43757/_isdir.2.7.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27533] release GIL in nt._isdir

Eryk Sun added the comment: Should this be backported to 2.7 posix__isdir()? -- nosy: +eryksun ___ Python tracker ___ ___ Python-bugs-

[issue27533] release GIL in nt._isdir

Steve Dower added the comment: LGTM. This is the kind of patch I can't wait to have a one-click merge button... right now it'll have to wait until I have a clean repo. But if anyone else wants to get it, go ahead. -- stage: -> patch review type: -> behavior versions: +Python 3.5, Py

[issue27533] release GIL in nt._isdir

Changes by R. David Murray : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___

[issue27533] release GIL in nt._isdir

New submission from Jeremy Spiegel: In Modules/posixmodule.c, the function os__isdir_impl calls GetFileAttributesA/GetFileAttributesW without releasing the GIL. This is problematic since it can result in disk or network I/O, depending on the filesystem. -- components: Library (Lib) fi