[issue27107] mailbox.__all__ list is incomplete

Martin Panter added the comment: FTR the closest thing I could find discussing reap_children() is Issue 16968. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27107] mailbox.__all__ list is incomplete

Roundup Robot added the comment: New changeset d62e57958e7c by Martin Panter in branch 'default': Issue #27107: mailbox.fcntl = None on Windows https://hg.python.org/cpython/rev/d62e57958e7c -- ___ Python tracker _

[issue27107] mailbox.__all__ list is incomplete

Roundup Robot added the comment: New changeset 4705b7597c86 by Martin Panter in branch 'default': Issue #27107: Add exception classes to mailbox.__all__, by Jacek Kołodziej https://hg.python.org/cpython/rev/4705b7597c86 -- nosy: +python-dev ___ Python

[issue27107] mailbox.__all__ list is incomplete

Martin Panter added the comment: This patch looks good to me. I agree the reap_children() thing is a separate problem. -- nosy: +martin.panter stage: -> patch review ___ Python tracker ___

[issue27107] mailbox.__all__ list is incomplete

Serhiy Storchaka added the comment: Yes, the reap_children call is the culprit. I think resolving this problem is out of the scope of this simple issue (there is separate issue for this). -- nosy: +serhiy.storchaka ___ Python tracker

[issue27107] mailbox.__all__ list is incomplete

R. David Murray added the comment: Look at your mimetypes patch, for example. That if __name__='__main__' clause is all that is needed. The test_main stuff can be dropped. The question, I suppose, is the reap_children call, and that may be why it hasn't been converted yet. --

[issue27107] mailbox.__all__ list is incomplete

Jacek Kołodziej added the comment: David, what do you mean by "new format"? Can you point me to some existing code? -- ___ Python tracker ___

[issue27107] mailbox.__all__ list is incomplete

R. David Murray added the comment: Rather than adding the new class to the list of tests, we could take this opportunity to convert this test file to the new format, unless there's some reason that doesn't work (I don't expect there to be). -- nosy: +r.david.murray ___

[issue27107] mailbox.__all__ list is incomplete

New submission from Jacek Kołodziej: That's a child issue of #23883, created to propose a patch fixing mailbox module's __all__ list. -- components: Library (Lib) files: mailbox_all.patch keywords: patch messages: 266267 nosy: Unit03 priority: normal severity: normal status: open title: