[issue2702] pickling of large recursive structures crashes cPickle

Facundo Batista <[EMAIL PROTECTED]> added the comment: Thanks Darryl. We'll continue in that issue, as the patched commited in this one did not introduce a regression (it just didn't fix the other bug also). ___ Python tracker <[EMAIL PROTECTED]>

[issue2702] pickling of large recursive structures crashes cPickle

Darryl Dixon <[EMAIL PROTECTED]> added the comment: Please check issue #3338 for a dup of this issue with a testcase that continues to fail after the application of r64595 -- nosy: +esrever_otua ___ Python tracker <[EMAIL PROTECTED]>

[issue2702] pickling of large recursive structures crashes cPickle

Facundo Batista <[EMAIL PROTECTED]> added the comment: Great, Amaury, I applied your second patch... it make all tests pass ok, :) Commited in 64595. Thank you all!! -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTE

[issue2702] pickling of large recursive structures crashes cPickle

Ralf Schmitt <[EMAIL PROTECTED]> added the comment: The tests pass on my machine (64 bit debian testing) with cpickle2.patch. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue2702] pickling of large recursive structures crashes cPickle

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Another version of the patch, that removes the self->nesting member and uses the Py_EnterRecursiveCall machinery. I prefer it because it takes into account the depth of the current python call stack. Added file: http://bugs.python.org/f

[issue2702] pickling of large recursive structures crashes cPickle

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: It seems that each self->nesting++ should be balanced with self->nesting--. Attached patch enables all tests and corrects the issue -- nosy: +amaury.forgeotdarc Added file: http://bugs.python.org/file10737/cpickle.patch ___

[issue2702] pickling of large recursive structures crashes cPickle

Facundo Batista <[EMAIL PROTECTED]> added the comment: I reverted the patch, because of #3179, so I'm reopening this. Note that I left the test in the suite, but commented out (if you find a patch that solves this, activate the test again). -- resolution: fixed -> status: closed -> ope

[issue2702] pickling of large recursive structures crashes cPickle

Facundo Batista <[EMAIL PROTECTED]> added the comment: Commited this patch to the test cases, and the patch from #3165 to fix the problem, thank you all! -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]>

[issue2702] pickling of large recursive structures crashes cPickle

Daniel Darabos <[EMAIL PROTECTED]> added the comment: It works for me as a test case too: test_deep_recursive (__main__.cPickleDeepRecursive) ... ERROR == ERROR: test_deep_recursive (__main__.cPickleDeepRecursive) -

[issue2702] pickling of large recursive structures crashes cPickle

Facundo Batista <[EMAIL PROTECTED]> added the comment: Daniel, it'd be great, because it does not crash in linux, so I can not test it... and I have a patch to apply (see issue 3165), so I wanted to test it that way. ___ Python tracker <[EMAIL PROTECTED]>

[issue2702] pickling of large recursive structures crashes cPickle

Daniel Darabos <[EMAIL PROTECTED]> added the comment: I have just quickly pasted it into an interpreter. Python 2.5 (r25:51908, Sep 19 2006, 09:52:17) [MSC v.1310 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> class Node(object): ... pass

[issue2702] pickling of large recursive structures crashes cPickle

Facundo Batista <[EMAIL PROTECTED]> added the comment: Could you please tell me if this problem arises with this test? -- keywords: +patch nosy: +facundobatista Added file: http://bugs.python.org/file10701/test_cpickle.diff ___ Python tracker <[EMAIL

[issue2702] pickling of large recursive structures crashes cPickle

Daniel Darabos <[EMAIL PROTECTED]> added the comment: Python 2.5 (r25:51908, Sep 19 2006, 09:52:17) [MSC v.1310 32 bit (Intel)] on win32 (Windows XP Professional 32 bits) __ Tracker <[EMAIL PROTECTED]> __

[issue2702] pickling of large recursive structures crashes cPickle

Martin v. Löwis <[EMAIL PROTECTED]> added the comment: What operating system and compiler are you using? -- nosy: +loewis __ Tracker <[EMAIL PROTECTED]> __

[issue2702] pickling of large recursive structures crashes cPickle

New submission from Daniel Darabos <[EMAIL PROTECTED]>: The documentation[1] says: Trying to pickle a highly recursive data structure may exceed the maximum recursion depth, a RuntimeError will be raised in this case. You can carefully raise this limit with sys.setrecursionlimit(). The li