[issue26924] android: test_concurrent_futures fails

Changes by Davin Potts : -- nosy: +davin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: > # undef sem_open I meant of course: # undef HAVE_SEM_OPEN -- ___ Python tracker ___ ___ Python

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: Undefining the SEM_* macros in multiprocessing.h when __ANDROID__ is set, would allow for an easier update when those functions become implemented at a future API level. The __ANDROID_API__ macro can be used for that purpose. For example, if this happens at AP

[issue26924] android: test_concurrent_futures fails

Berker Peksag added the comment: Thanks! Perhaps we should not set HAVE_SEM_* to 1 if we are on Android in the configure step. -- ___ Python tracker ___

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: sem_open() is not implemented as well. Here is a gdb session with a breakpoint set at semlock_new() (SEM_FAILED is NULL on android): Breakpoint 1, semlock_new (type=0xb6d070c0 <_PyMp_SemLockType>, args=(1, 1, 1, '/mp-dkzrq4ed', True), kwds=0x0) at /ho

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: There is a typo in sem_unlink_alt.diff, not in the patch itself but in the neighbouring lines. In Modules/_multiprocessing/semaphore.c, it should be, I think, after one does 's/define sem_unlink(name)/define SEM_UNLINK(name)/': @@ -194,8 +194,8 @@ # define S

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: Attached the results with sem_unlink_alt.diff. -- Added file: http://bugs.python.org/file42774/sem_unlink_alt_output.txt ___ Python tracker ___

[issue26924] android: test_concurrent_futures fails

Berker Peksag added the comment: Xavier, could you try this alternative patch? -- Added file: http://bugs.python.org/file42773/sem_unlink_alt.diff ___ Python tracker ___

[issue26924] android: test_concurrent_futures fails

Roundup Robot added the comment: New changeset eee959fee5f5 by Berker Peksag in branch 'default': Issue #26924: Fix Windows buildbots https://hg.python.org/cpython/rev/eee959fee5f5 -- ___ Python tracker ___

[issue26924] android: test_concurrent_futures fails

Berker Peksag added the comment: Thanks, Xavier. -- components: +Extension Modules -Cross-Build, Library (Lib) resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue26924] android: test_concurrent_futures fails

Roundup Robot added the comment: New changeset 1030aa8357a7 by Berker Peksag in branch 'default': Issue #26924: Do not define _multiprocessing.sem_unlink under Android https://hg.python.org/cpython/rev/1030aa8357a7 -- nosy: +python-dev ___ Python trac

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: > Here is the result of the test: I meant, results with the new patch. -- ___ Python tracker ___ __

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: Here is the result of the test: root@generic_x86:/data/local/tmp # python -m test -v test_concurrent_futures == CPython 3.6.0a0 (default:811ccdee6f87+, May 7 2016, 18:51:28) [GCC 4.9 20140827 (prerelease)] == Linux-3.4.67+-i686-with-libc little-endian == ha

[issue26924] android: test_concurrent_futures fails

Berker Peksag added the comment: Thanks for testing. Here is a new patch. -- stage: -> patch review Added file: http://bugs.python.org/file42769/sem_unlink_v2.diff ___ Python tracker __

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: Patch tested, it does not fix the problem. This is because in pyconfig.h: /* Define to 1 if you have the `sem_unlink' function. */ #define HAVE_SEM_UNLINK 1 Android declares the function but does not implement it. This is not the only case, for example issue #2

[issue26924] android: test_concurrent_futures fails

Berker Peksag added the comment: It normally should raise an ImportError if sem_unlink is not available. Could you try the attached patch please? -- keywords: +patch nosy: +berker.peksag Added file: http://bugs.python.org/file42710/sem_unlink.diff __

[issue26924] android: test_concurrent_futures fails

Xavier de Gaye added the comment: On android: root@generic_x86:/data/local/tmp # python Python 3.6.0a0 (default:811ccdee6f87+, May 4 2016, 10:31:14) [GCC 4.9 20140827 (prerelease)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> from _multiprocessing import

[issue26924] android: test_concurrent_futures fails

New submission from Xavier de Gaye: test_concurrent_futures fails on an android emulator running an x86 system image at API level 21. There are multiple ERRORs, all resulting in the same traceback: Traceback (most recent call last): File "/sdcard/org.bitbucket.pyona/lib/python3.6/test/test_