[issue26876] Extend MSVCCompiler class to respect environment variables

Steve Dower added the comment: Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils. If this issue does not relate to distutils, please remove the component and reopen it. If y

[issue26876] Extend MSVCCompiler class to respect environment variables

Steve Dower added the comment: Taking another look at the patch, I'm not real keen on the C/LDFLAGS section. I think if we want to support setting these, we should fully override the default settings (otherwise you can't specify certain options that are in the defaults), and avoid splitting th

[issue26876] Extend MSVCCompiler class to respect environment variables

Rohit Jamuar added the comment: Steve, I've limited the changes to _msvccompiler for the master-branch's patch. Is it alright? -- ___ Python tracker ___

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : Added file: http://bugs.python.org/file45881/distutils_patch_master.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : Removed file: http://bugs.python.org/file45880/distutils_patch_master.patch ___ Python tracker ___ ___ Python-bugs-l

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : Added file: http://bugs.python.org/file45880/distutils_patch_master.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : Removed file: http://bugs.python.org/file42725/distutils_patch_master.patch ___ Python tracker ___ ___ Python-bugs-l

[issue26876] Extend MSVCCompiler class to respect environment variables

Steve Dower added the comment: I'd rather only take the change to _msvccompiler and not the ones that are there for historical interest (a.k.a. backwards compatibility with people who never expect internal implementation details to change). If any tools break because they're using the wrong co

[issue26876] Extend MSVCCompiler class to respect environment variables

Zachary Ware added the comment: Steve, does the latest patch look good to you? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26876] Extend MSVCCompiler class to respect environment variables

Rohit Jamuar added the comment: Bump! The changes, that Steve was asking for, have been incorporated. If something was missed, please inform. Otherwise, could this be merged? -- ___ Python tracker

[issue26876] Extend MSVCCompiler class to respect environment variables

Steve Dower added the comment: I still want the behavior I described, since there's no value in overriding just the executable name but not the rest of the path. For 2.7 I think this'll help with long term maintainability enough to be the Right Thing. For 3.5 I'm not as sure, but it's probably

[issue26876] Extend MSVCCompiler class to respect environment variables

Zachary Ware added the comment: The patch looks fine to me, but frankly I'm a bit scared to commit anything to distutils :). It would be nice to have tests for this. I'm also not sure if we can backport this to 2.7 and 3.5: this is pretty clearly a new feature, but dips its toes into the grey

[issue26876] Extend MSVCCompiler class to respect environment variables

Zachary Ware added the comment: (The version field is for the whole issue, not per patch.) -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___ ___

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : -- versions: +Python 2.7 -Python 3.5, Python 3.6 Added file: http://bugs.python.org/file42726/distutils_patch_27.patch ___ Python tracker ___ __

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : -- versions: +Python 3.6 -Python 2.7 Added file: http://bugs.python.org/file42725/distutils_patch_master.patch ___ Python tracker ___ __

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Rohit Jamuar : Removed file: http://bugs.python.org/file42642/msvc_respect_env_flags.patch ___ Python tracker ___ ___ Python-bugs-l

[issue26876] Extend MSVCCompiler class to respect environment variables

Steve Dower added the comment: I was thinking more like this: if DISTUTILS_USE_SDK: assume PATH is configured execute os.getenv("CC", "cl.exe") directly else: find VS in the registry execute "cl.exe" etc. The only change here from the current situation is preferring the CC varia

[issue26876] Extend MSVCCompiler class to respect environment variables

Rohit Jamuar added the comment: Just so that I understand it clearly - Inside MSVCCompiler class (in _msvccompiler.py / msvccompiler.py / msvc9compiler.py ), current implementation of find_exe() finds compiler / linker / ... after parsing PATH. Should the changes be so, that if DISTUTILS_USE_S

[issue26876] Extend MSVCCompiler class to respect environment variables

Steve Dower added the comment: I'm neutral about applying it to 2.7, though I can see the value in doing so. For 3.5 it definitely has to modify _msvccompiler - the other two modules are just left behind to distract people apparently :) (but actually in case someone accidentally(?) too a direc

[issue26876] Extend MSVCCompiler class to respect environment variables

Zachary Ware added the comment: I can't seem to get the patch to apply, could you please regenerate it against a fresh checkout of https://hg.python.org/cpython#default (or 'master' of github.com/python/cpython)? This looks fairly straightforward, but I'm far from an expert on distutils :).

[issue26876] Extend MSVCCompiler class to respect environment variables

Changes by Zachary Ware : -- nosy: +christopher.hogan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue26876] Extend MSVCCompiler class to respect environment variables

New submission from Rohit Jamuar: The UnixCompiler class respects flags (CC, LD, AR, CFLAGS and LDFLAGS) set to the environment, whereas MSVCCompiler class does not. This change allows building CPython and any module that invokes distutils to utilize flags and executables that have been set to