[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

cschramm added the comment: Well, the 3.5 code checks __ANDROID__ as well and works pretty fine on Android, but if it's not supposed to be supported, we'll have to upgrade to 3.6 then. Thanks for your work! :) -- ___ Python tracker

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Xavier de Gaye added the comment: Sorry, AFAIK there is no plan to retrofit the Android changes to 3.5. Note that Python 3.6 is expected to be released in few weeks, by next mid-december. -- ___ Python tracker ___

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Chi Hsuan Yen added the comment: cschramm: AFAIK only Python 3.6+ has experimental Android support. 3.5 or below are not supported. -- nosy: +Chi Hsuan Yen ___ Python tracker __

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

cschramm added the comment: Any plans to fix this in 3.5 as well? -- nosy: +cschramm ___ Python tracker ___ ___ Python-bugs-list maili

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Changes by Xavier de Gaye : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ __

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Roundup Robot added the comment: New changeset 4ef3a93e1be2 by Xavier de Gaye in branch 'default': Issue #26862: SYS_getdents64 does not need to be defined on android API 21. https://hg.python.org/cpython/rev/4ef3a93e1be2 -- nosy: +python-dev ___ Pyth

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

STINNER Victor added the comment: Stefan Krah: "posixmodule_3.patch looks good to me. Gregory has already approved the approach, so I think you can go ahead and commit this" I concur with Stefan: LGTM. -- nosy: +haypo ___ Python tracker

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Changes by Xavier de Gaye : -- assignee: -> xdegaye stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Stefan Krah added the comment: posixmodule_3.patch looks good to me. Gregory has already approved the approach, so I think you can go ahead and commit this. -- ___ Python tracker __

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Xavier de Gaye added the comment: The patch is simpler since android/api-level.h is now included in pyport.h by changeset 09af54099973. -- Added file: http://bugs.python.org/file43234/posixmodule_3.patch ___ Python tracker

[issue26862] android: SYS_getdents64 does not need to be defined on android API 21

Changes by Xavier de Gaye : -- title: SYS_getdents64 does not need to be defined on android API 21 -> android: SYS_getdents64 does not need to be defined on android API 21 ___ Python tracker __