[issue26092] doctest should allow custom sys.displayhook

Change by Sergey B Kirpichev : -- pull_requests: +24342 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25651 ___ Python tracker ___ __

[issue26092] doctest should allow custom sys.displayhook

Noam Yorav-Raphael added the comment: Yes, sorry, I didn't remember the history exactly. I don't have a strong opinion. I'm okay with reverting the behavior to use sys.displayhook. Thanks, Noam -- ___ Python tracker

[issue26092] doctest should allow custom sys.displayhook

Sergey B Kirpichev added the comment: > I personally haven't encountered this problem in the past years Noam, that's because Python has your patch :-) But if we revert one - mentioned solution with mock.patch will work. Please, tell us if you find it bad for any reason. -- ___

[issue26092] doctest should allow custom sys.displayhook

Noam Yorav-Raphael added the comment: Hi, I think that using mock.patch to fix the problem is fine. I personally haven't encountered this problem in the past years, so whatever you decide is fine by me. Thanks! Noam On Mon, Apr 26, 2021 at 10:08 AM Sergey B Kirpichev wrote: > > Sergey B Ki

[issue26092] doctest should allow custom sys.displayhook

Sergey B Kirpichev added the comment: Tim, lets decide on this simple issue. To me, https://bugs.python.org/issue8048 was obviously a bad thing. While it "fixes" one application, which customize sys.displayhook in a strange way - it break testing almost everyone, which do sys.displayhook cu

[issue26092] doctest should allow custom sys.displayhook

Noam Yorav-Raphael added the comment: Tim, thanks for letting me know. I certainly don't mind if you close this bug, since it undoes my old (and still relevant) fix. -- nosy: +noamraph ___ Python tracker __

[issue26092] doctest should allow custom sys.displayhook

Tim Peters added the comment: Oops! Should be issue 8048. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26092] doctest should allow custom sys.displayhook

Tim Peters added the comment: Noam Yorav-Raphael, I tried to add you because this is pushing back against your patch in issue 8408. It's been some years now, and nobody has cared enough to pursue it, so I'll just close this if you still don't care ;-) As doctest's original author, I appreci

[issue26092] doctest should allow custom sys.displayhook

Change by Tim Peters : -- nosy: +noam, tim.peters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26092] doctest should allow custom sys.displayhook

Sergey B Kirpichev added the comment: > What problem does replacing __displayhook__ provoke? I don't know for sure. But the documentation says "These objects contain the original values of displayhook and excepthook at the start of the program." So, other code in stdlib may assume something

[issue26092] doctest should allow custom sys.displayhook

R. David Murray added the comment: What problem does replacing __displayhook__ provoke? What solution do you propose instead of 8048, which fixed a bug? -- nosy: +r.david.murray ___ Python tracker ___

[issue26092] doctest should allow custom sys.displayhook

Changes by SilentGhost : -- nosy: +georg.brandl versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue26092] doctest should allow custom sys.displayhook

New submission from Sergey B Kirpichev: The purpose of doctest's - verify interactive examples. But if your users will use custom displayhook all the time (consider, as examples CAS like SymPy or https://github.com/skirpichev/omg/) - why you must show them examples with the builtin's displayhook