[issue25725] Memory leak on unpickling bogus data

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue25725] Memory leak on unpickling bogus data

Roundup Robot added the comment: New changeset c85eca74f3a5 by Serhiy Storchaka in branch '3.4': Issue #25725: Fixed a reference leak in pickle.loads() when unpickling https://hg.python.org/cpython/rev/c85eca74f3a5 New changeset 88ad2b8480b1 by Serhiy Storchaka in branch '3.5': Issue #25725: Fix

[issue25725] Memory leak on unpickling bogus data

Serhiy Storchaka added the comment: You patch is just the first version of my patch. :-) But tests are crashed with it. -- ___ Python tracker ___ __

[issue25725] Memory leak on unpickling bogus data

STINNER Victor added the comment: I reviewed load_counted_tuple_leak.patch. Forget my patch, Serhiy's patch is better. -- ___ Python tracker ___

[issue25725] Memory leak on unpickling bogus data

STINNER Victor added the comment: Oh... I didn't notice that you wrote a patch :-) I started to write a similar patch: see attached pickle.patch. -- Added file: http://bugs.python.org/file41156/pickle.patch ___ Python tracker

[issue25725] Memory leak on unpickling bogus data

Serhiy Storchaka added the comment: $ ./python -m test.regrtest -R 3:3 -m test_bad_stack test_pickle [1/1] test_pickle beginning 6 repetitions 123456 .. test_pickle leaked [20, 20, 20] references, sum=60 test_pickle leaked [12, 14, 14] memory blocks, sum=40 1 test failed: test_pickle ---

[issue25725] Memory leak on unpickling bogus data

New submission from Serhiy Storchaka: New tests added in issue23914 exposed memory leak on unpickling TUPLE1..TUPLE3 opcodes with insufficient stack. Proposed patch fixes the leak. -- assignee: serhiy.storchaka components: Library (Lib) keywords: patch messages: 255289 nosy: alexandre.v

[issue25725] Memory leak on unpickling bogus data

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python