[issue25671] Fix venv activate.fish to maintain $status

Roundup Robot added the comment: New changeset f6125944ffb8 by Vinay Sajip in branch '3.5': Fixes #25671: Updated prompt handling in activate.fish. https://hg.python.org/cpython/rev/f6125944ffb8 New changeset ed34b93519ba by Vinay Sajip in branch 'default': Closes #25671: Merged fix from 3.5. ht

[issue25671] Fix venv activate.fish to maintain $status

Changes by Ned Deily : -- nosy: +vinay.sajip versions: -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue25671] Fix venv activate.fish to maintain $status

Nathan West added the comment: Not quite, no. The issue looks like this: user@host ~/test> python3 -mvenv env user@host ~/test> true user@host ~/test> false user@host ~/test [1]> source env/bin/activate.fish (env) user@host ~/test> true (env) user@host ~/test> false

[issue25671] Fix venv activate.fish to maintain $status

Stéphane Wirtel added the comment: I am a user of fish. The use case is just execute python -mvenv demo source demo/bin/activate.fish check the status and deactivate the virtualenv ? do you confirm ? Thank you -- nosy: +matrixise ___ Python track

[issue25671] Fix venv activate.fish to maintain $status

Nathan West added the comment: Fixed an issue where fish_prompt was returning before calling _old_fish_prompt -- Added file: http://bugs.python.org/file41103/patch.diff ___ Python tracker __

[issue25671] Fix venv activate.fish to maintain $status

New submission from Nathan West: Many fish_prompts use display the $status (fish's equivalent to $?) somewhere in the prompt. Currently, venv's activate.fish overwrites and wraps the user's fish_prompt, the wrapping doesn't preserve this $status. This patch ensures that the $status is correctl