[issue25556] Fixes for PyObject_GetItem()

STINNER Victor added the comment: > In issue25557 I mentioned that there is the same error for globals which are > dict. This issue fixed a bug for LOAD_GLOBAL bytecode bytecode when globals are not dict. (Sorry, I wrote LOAD_NAME bytecode in my first message, it was a mistake.) Please discus

[issue25556] Fixes for PyObject_GetItem()

Serhiy Storchaka added the comment: In issue25557 I mentioned that there is the same error for globals which are dict. -- ___ Python tracker ___

[issue25556] Fixes for PyObject_GetItem()

STINNER Victor added the comment: > What about 3.4? I consider it as almost dead (no more bugfixes), and this really is really a corner case. Except me, I don't think that anyone uses globals which are not dict :-D (It never worked...) -- ___ Pytho

[issue25556] Fixes for PyObject_GetItem()

Serhiy Storchaka added the comment: What about 3.4? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue25556] Fixes for PyObject_GetItem()

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed versions: +Python 3.5 ___ Python tracker ___ ___ Python-bu

[issue25556] Fixes for PyObject_GetItem()

STINNER Victor added the comment: > LGTM. The fix for LOAD_GLOBAL should be applied for all versions. Thanks for the review. I applied the LOAD_GLOBAL fix to Python 3.5 and 3.6. Python 2.7 doesn't support globals not being dict. -- ___ Python tracke

[issue25556] Fixes for PyObject_GetItem()

Roundup Robot added the comment: New changeset 1e87bcf20707 by Victor Stinner in branch '3.5': Issue #25556: Fix LOAD_GLOBAL bytecode when globals type is not dict and the https://hg.python.org/cpython/rev/1e87bcf20707 New changeset c1414f80ebc9 by Victor Stinner in branch 'default': Issue #2555

[issue25556] Fixes for PyObject_GetItem()

Serhiy Storchaka added the comment: LGTM. The fix for LOAD_GLOBAL should be applied for all versions. -- assignee: -> haypo stage: patch review -> commit review ___ Python tracker _

[issue25556] Fixes for PyObject_GetItem()

Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue25556] Fixes for PyObject_GetItem()

STINNER Victor added the comment: Oops, sorry. It's now attached to the issue :-) -- keywords: +patch Added file: http://bugs.python.org/file40951/pyobject_getitem.patch ___ Python tracker _

[issue25556] Fixes for PyObject_GetItem()

Serhiy Storchaka added the comment: Where is a patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue25556] Fixes for PyObject_GetItem()

New submission from STINNER Victor: Attached patch adds assertions to PyObject_GetItem() to ensure that an exception is raised if the function failed. _Py_CheckFunctionResult() could be used to implement such check, but it might adds a little overhead, whereas I really don't think that such bu