[issue25262] Issues with BINUNICODE8 and BINBYTES8 opcodes in pickle

Serhiy Storchaka added the comment: Thank you Victor and Antoine for your reviews. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25262] Issues with BINUNICODE8 and BINBYTES8 opcodes in pickle

Roundup Robot added the comment: New changeset d4f8316d0860 by Serhiy Storchaka in branch '3.4': Issue #25262. Added support for BINBYTES8 opcode in Python implementation of https://hg.python.org/cpython/rev/d4f8316d0860 New changeset da9ad20dd470 by Serhiy Storchaka in branch '3.5': Issue #2526

[issue25262] Issues with BINUNICODE8 and BINBYTES8 opcodes in pickle

Serhiy Storchaka added the comment: > To access an array item, the type of the index variable must be size_t (or a > type with the same size), otherwise the compiler produce less efficient > machine code: http://www.viva64.com/en/a/0050/ > > => please keep Py_ssize_t type for i i is small integ

[issue25262] Issues with BINUNICODE8 and BINBYTES8 opcodes in pickle

STINNER Victor added the comment: To access an array item, the type of the index variable must be size_t (or a type with the same size), otherwise the compiler produce less efficient machine code: http://www.viva64.com/en/a/0050/ => please keep Py_ssize_t type for i (I didn't check for the sp

[issue25262] Issues with BINUNICODE8 and BINBYTES8 opcodes in pickle

New submission from Serhiy Storchaka: There are issues with BINUNICODE8 and BINBYTES8 opcodes in pickle. 1. Unpickling BINBYTES8 is not implemented in Python implementation. 2. Highest 32 bits of 64-bit size are silently ignored in C implementation on 32-bit platforms. 3. There are no tests f