[issue25057] Make parameter of io.base to be positional and keyword

2015-09-19 Thread Martin Panter
Martin Panter added the comment: For an illustration of the problem that this would cause, I did a quick search through Python’s own source tree. It already has various keyword names: def seek(self, pos, whence=0): def seek(self, cookie, whence=0): def seek(self, offset, whence=0): def seek(sel

[issue25057] Make parameter of io.base to be positional and keyword

2015-09-11 Thread shiyao.ma
shiyao.ma added the comment: You've listed much of the benefits it can bring about. The real problem is there are many places like iobase.seek to modify to support keyword argument, and seems not many people think it's a good idea to do that, per issue 8706. But I think the former is the main hi

[issue25057] Make parameter of io.base to be positional and keyword

2015-09-10 Thread Martin Panter
Martin Panter added the comment: I’m not sure this is a good idea. IOBase is a base class, so adding to its API really means everybody’s subclasses may need to be updated to support the proper keyword argument names. Even ignoring classes outside Python’s standard library, it looks like you wo

[issue25057] Make parameter of io.base to be positional and keyword

2015-09-10 Thread shiyao.ma
New submission from shiyao.ma: The parameters for io.[Text]IOBase.seek are currently positional only, as discussed in http://bugs.python.org/issue25030. We make the parameters to be both positional and keyword based. -- files: patch.diff keywords: patch messages: 250382 nosy: berker.pe