[issue25001] Make --nowindows argument to regrtest propagate when running with -j

STINNER Victor added the comment: We are good, I close the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Steve Dower added the comment: Between Victor's fix and #23919, is there anything left to do for this? -- ___ Python tracker ___ ___ P

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Zachary Ware added the comment: Just to add my 0.02USD: I think my preferred course of action would be to enable '-n' by default and deprecate/ignore the option. For the assert output on stderr, I think it would be fine to hide it by default, but show it if verbose > i for some value of i (0

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Steve Dower added the comment: I was only going to disable them by default for regrtest. The only way users will see them is when using the debug binaries or in their own extensions built in debug mode. We just don't want them scaring users who have just built from source and don't know about

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

STINNER Victor added the comment: > Yes. Modify PCbuild/rt.bat and/or Tools/buildbot/test.bat to enable > the option on Windows buildbots. Wait, I'm not sure that I understood. You want to hide warnings by default, and add an options to show them? If it's the case, no, PCbuild/rt.bat and Tools/b

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

STINNER Victor added the comment: Steve Dower added the comment: > So basically what I said (-n becomes redundant) ok > and a new option for logging asserts to stderr? Yes. Modify PCbuild/rt.bat and/or Tools/buildbot/test.bat to enable the option on Windows buildbots. --

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Steve Dower added the comment: So basically what I said (-n becomes redundant) and a new option for logging asserts to stderr? I don't really mind, but it seems like more of a compatibility break. -- ___ Python tracker

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

STINNER Victor added the comment: Steve wrote: "I'd be happy to always disable assert dialogs/output in regrtest, and then use "-n" to enable stderr output. That way people simply testing their own debug builds don't think it's failed, and the buildbots keep all the output they currently have.

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

STINNER Victor added the comment: This issue has been fixed by the following change: changeset: 98427:b48ae54ed5be user:Victor Stinner date:Wed Sep 30 01:39:28 2015 +0200 files: Lib/test/libregrtest/cmdline.py Lib/test/libregrtest/main.py Lib/te description: Issue #25220

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Brett Cannon added the comment: Steve's idea SGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

Steve Dower added the comment: I'd be happy to always disable assert dialogs/output in regrtest, and then use "-n" to enable stderr output. That way people simply testing their own debug builds don't think it's failed, and the buildbots keep all the output they currently have. -- vers

[issue25001] Make --nowindows argument to regrtest propagate when running with -j

New submission from Brett Cannon: Not sure how feasible this is, but when running tests under Windows it's very nice to run with --nowindows on, else you get barraged with a ton of debugging warnings. The problem is that if you use -j the use of --nowindows gets turned off. It would be nice if